fix: review update

Author: cdcabrera

src/__tests__/__snapshots__/server.search.test.ts.snap

@@ -91,6 +91,16 @@ exports[`findClosest should attempt to find a closest match, undefined items 1`]
 }
 `;
 
+exports[`findClosest should handle numbers in addition to strings, float against float query 1`] = `123.44`;
+
+exports[`findClosest should handle numbers in addition to strings, float number query 1`] = `123`;
+
+exports[`findClosest should handle numbers in addition to strings, number query 1`] = `123`;
+
+exports[`findClosest should handle numbers in addition to strings, number query with float 1`] = `123.45`;
+
+exports[`findClosest should handle numbers in addition to strings, string query 1`] = `"Button"`;
+
 exports[`fuzzySearch should fuzzy match, contains match multiple 1`] = `
 {
   "results": [
@@ -549,7 +559,7 @@ exports[`fuzzySearch should fuzzy match, undefined items 1`] = `
 }
 `;
 
-exports[`fuzzySearch should handle numbers in addition to strings, exact number query with strings 1`] = `
+exports[`fuzzySearch should handle numbers in addition to strings, exact number query 1`] = `
 {
   "results": [
     {
@@ -591,7 +601,7 @@ exports[`fuzzySearch should handle numbers in addition to strings, prefix number
 }
 `;
 
-exports[`fuzzySearch should handle numbers in addition to strings, string query with numbers 1`] = `
+exports[`fuzzySearch should handle numbers in addition to strings, string query 1`] = `
 {
   "results": [
     {

src/__tests__/server.search.test.ts

@@ -82,7 +82,7 @@ describe('findClosest', () => {
   ])('should attempt to find a closest match, $description', ({ query, items }) => {
     expect({
       query,
-      match: findClosest(query, items as string[])
+      match: findClosest(query, items as any)
     }).toMatchSnapshot();
   });
 
@@ -95,6 +95,36 @@ describe('findClosest', () => {
       findClosest('button', ['Button', 'Badge'], { normalizeFn: throwingNormalizeFn });
     }).toThrow('Normalization failed');
   });
+
+  it.each([
+    {
+      description: 'string query',
+      query: 'button',
+      items: ['Button', 123, 'Badge']
+    },
+    {
+      description: 'number query',
+      query: 123,
+      items: ['Button', 123, 'Badge']
+    },
+    {
+      description: 'number query with float',
+      query: 123,
+      items: ['Button', 123.45, 'Badge']
+    },
+    {
+      description: 'float number query',
+      query: 123.45,
+      items: ['Button', 123, 'Badge']
+    },
+    {
+      description: 'float against float query',
+      query: 123.45,
+      items: ['Button', 123, undefined, 123.44, 'Badge', null]
+    }
+  ])('should handle numbers in addition to strings, $description', ({ query, items }) => {
+    expect(findClosest(query, items as any)).toMatchSnapshot();
+  });
 });
 
 describe('fuzzySearch', () => {
@@ -312,7 +342,7 @@ describe('fuzzySearch', () => {
       }
     }
   ])('should fuzzy match, $description', ({ query, items, options }) => {
-    expect(fuzzySearch(query, items as string[], options)).toMatchSnapshot();
+    expect(fuzzySearch(query, items as any, options)).toMatchSnapshot();
   });
 
   it('should handle normalizeFn errors in fuzzySearch', () => {
@@ -327,12 +357,12 @@ describe('fuzzySearch', () => {
 
   it.each([
     {
-      description: 'string query with numbers',
+      description: 'string query',
       query: 'button',
       items: ['Button', 123, 'Badge']
     },
     {
-      description: 'exact number query with strings',
+      description: 'exact number query',
       query: 123,
       items: ['Button', 123, 'Badge']
     },

src/server.search.ts

@@ -88,7 +88,7 @@ interface FuzzySearchOptions {
  * @param str
  * @returns Normalized or empty string
  */
-const normalizeString: NormalizeString = (str: string | number) => String(str || '')
+const normalizeString: NormalizeString = (str: string | number) => String(str ?? '')
   .trim()
   .toLowerCase()
   .normalize('NFKD')
@@ -121,7 +121,7 @@ normalizeString.memo = memo(normalizeString, { cacheLimit: 50 });
  * ```
  */
 const findClosest = (
-  query: string,
+  query: string | number,
   items: (string | number)[] = [],
   {
     normalizeFn = normalizeString.memo
@@ -133,7 +133,7 @@ const findClosest = (
     return null;
   }
 
-  const normalizedItems = items.map(item => normalizeFn(item)).filter(Boolean);
+  const normalizedItems = items.map(item => normalizeFn(item));
   const closestMatch = closest(normalizedQuery, normalizedItems);
 
   return items[normalizedItems.indexOf(closestMatch)] || null;