fix: review update

Author: cdcabrera

src/__tests__/__snapshots__/tool.searchPatternFlyDocs.test.ts.snap

@@ -10,6 +10,8 @@ exports[`searchPatternFlyDocsTool should have a consistent return structure: str
 
 exports[`searchPatternFlyDocsTool, callback should parse parameters, default: search 1`] = `"# Search results for "Button". Showing 1 exact match."`;
 
+exports[`searchPatternFlyDocsTool, callback should parse parameters, explicit valid version: search 1`] = `"# Search results for "Button". Showing 1 exact match."`;
+
 exports[`searchPatternFlyDocsTool, callback should parse parameters, with "*" searchQuery all: search 1`] = `"# Search results for "all" resources. Only showing the first 10 results. There are 546 potential match variations. Try searching with a more specific query."`;
 
 exports[`searchPatternFlyDocsTool, callback should parse parameters, with "all" searchQuery all: search 1`] = `"# Search results for "all" resources. Only showing the first 10 results. There are 546 potential match variations. Try searching with a more specific query."`;

src/__tests__/resource.patternFlyComponentsIndex.test.ts

@@ -25,6 +25,13 @@ describe('resourceCallback', () => {
       variables: {},
       expected: '# PatternFly Component Names Index for "v6"'
     },
+    {
+      description: 'explicit valid version',
+      variables: {
+        version: 'v6'
+      },
+      expected: '# PatternFly Component Names Index for "v6"'
+    },
     {
       description: 'category',
       variables: {

src/__tests__/resource.patternFlyDocsIndex.test.ts

@@ -25,6 +25,13 @@ describe('resourceCallback', () => {
       variables: {},
       expected: '# PatternFly Documentation Index for "v6"'
     },
+    {
+      description: 'explicit valid version',
+      variables: {
+        version: 'v6'
+      },
+      expected: '# PatternFly Documentation Index for "v6"'
+    },
     {
       description: 'category',
       variables: {

src/__tests__/resource.patternFlyDocsTemplate.test.ts

@@ -43,6 +43,12 @@ describe('resourceCallback', () => {
   });
 
   it.each([
+    {
+      description: 'no version',
+      variables: {
+        name: 'Button'
+      }
+    },
     {
       description: 'default',
       variables: {
@@ -84,25 +90,44 @@ describe('resourceCallback', () => {
   });
 
   it.each([
+    {
+      description: 'invalid version',
+      error: 'Invalid PatternFly version',
+      variables: {
+        name: 'Button',
+        version: 'v5'
+      }
+    },
     {
       description: 'with missing or undefined name',
       error: 'must be a string',
-      variables: { version: 'v6' }
+      variables: {
+        version: 'v6'
+      }
     },
     {
       description: 'with null name',
       error: 'must be a string',
-      variables: { name: null, version: 'v6' }
+      variables: {
+        name: null,
+        version: 'v6'
+      }
     },
     {
       description: 'with empty name',
       error: 'must be a string',
-      variables: { name: '', version: 'v6' }
+      variables: {
+        name: '',
+        version: 'v6'
+      }
     },
     {
       description: 'with non-string name',
       error: 'must be a string',
-      variables: { name: 123, version: 'v6' }
+      variables: {
+        name: 123,
+        version: 'v6'
+      }
     }
   ])('should handle variable errors, $description', async ({ error, variables }) => {
     const mockContent = `Mock content for ${variables.name}`;

src/__tests__/resource.patternFlySchemasIndex.test.ts

@@ -32,6 +32,13 @@ describe('resourceCallback', () => {
       description: 'default',
       variables: {},
       expected: '# PatternFly Component JSON Schemas Index for "v6"'
+    },
+    {
+      description: 'explicit valid version',
+      variables: {
+        version: 'v6'
+      },
+      expected: '# PatternFly Component JSON Schemas Index for "v6"'
     }
   ])('should return component schemas index, $description', async ({ variables, expected }) => {
     const result = await resourceCallback(undefined as any, variables);

src/__tests__/resource.patternFlySchemasTemplate.test.ts

@@ -25,6 +25,7 @@ describe('resourceCallback', () => {
   });
 
   it.each([
+    { description: 'no version', variables: { name: 'Button' } },
     {
       description: 'default',
       variables: {
@@ -53,6 +54,14 @@ describe('resourceCallback', () => {
   });
 
   it.each([
+    {
+      description: 'invalid version',
+      error: 'Invalid PatternFly version',
+      variables: {
+        name: 'Button',
+        version: 'v5'
+      }
+    },
     {
       description: 'with missing or undefined name',
       error: 'must be a string',
@@ -61,27 +70,39 @@ describe('resourceCallback', () => {
     {
       description: 'with null name',
       error: 'must be a string',
-      variables: { name: null }
+      variables: {
+        name: null
+      }
     },
     {
       description: 'with empty name',
       error: 'must be a string',
-      variables: { name: '' }
+      variables: {
+        name: ''
+      }
     },
     {
       description: 'with non-string name',
       error: 'must be a string',
-      variables: { name: 123 }
+      variables: {
+        name: 123
+      }
     },
     {
       description: 'non-existent name',
       error: 'No component JSON schemas found',
-      variables: { name: 'loremIpsum', version: 'v6' }
+      variables: {
+        name: 'loremIpsum',
+        version: 'v6'
+      }
     },
     {
       description: 'found but no schema',
       error: 'No component JSON schemas found',
-      variables: { name: 'table', version: 'v6' }
+      variables: {
+        name: 'table',
+        version: 'v6'
+      }
     }
   ])('should handle variable errors, $description', async ({ error, variables }) => {
     await expect(resourceCallback(undefined as any, variables as any)).rejects.toThrow(McpError);

src/__tests__/tool.searchPatternFlyDocs.test.ts

@@ -29,6 +29,11 @@ describe('searchPatternFlyDocsTool, callback', () => {
   });
 
   it.each([
+    {
+      description: 'explicit valid version',
+      searchQuery: 'Button',
+      version: 'v6'
+    },
     {
       description: 'default',
       searchQuery: 'Button'

src/resource.patternFlyComponentsIndex.ts

@@ -55,7 +55,7 @@ const resourceCallback = async (passedUri: URL, variables: Record<string, string
   const normalizedVersion = await normalizeEnumeratedPatternFlyVersion.memo(version);
 
   assertInput(
-    !version && !normalizedVersion,
+    !version || Boolean(normalizedVersion),
     `Invalid PatternFly version "${version?.trim()}". Available versions are: ${availableVersions.join(', ')}`
   );
 

src/resource.patternFlyDocsIndex.ts

@@ -62,7 +62,7 @@ const resourceCallback = async (passedUri: URL, variables: Record<string, string
   const normalizedVersion = await normalizeEnumeratedPatternFlyVersion.memo(version);
 
   assertInput(
-    !version && !normalizedVersion,
+    !version || Boolean(normalizedVersion),
     `Invalid PatternFly version "${version?.trim()}". Available versions are: ${availableVersions.join(', ')}`
   );
 

src/resource.patternFlyDocsTemplate.ts

@@ -66,14 +66,14 @@ const resourceCallback = async (passedUri: URL, variables: Record<string, string
   }
 
   const { availableVersions, latestVersion } = await getPatternFlyMcpResources.memo();
-  const normalizedVersion = (await normalizeEnumeratedPatternFlyVersion.memo(version)) || latestVersion;
+  const normalizedVersion = await normalizeEnumeratedPatternFlyVersion.memo(version);
 
   assertInput(
-    normalizedVersion,
+    !version || Boolean(normalizedVersion),
     `Invalid PatternFly version "${version?.trim()}". Available versions are: ${availableVersions.join(', ')}`
   );
 
-  const updatedVersion = normalizedVersion;
+  const updatedVersion = normalizedVersion || latestVersion;
   const updatedName = name.trim();
 
   const { byEntry } = await filterPatternFly.memo({