fix: review update

Author: cdcabrera

src/__tests__/__snapshots__/patternFly.getResources.test.ts.snap

@@ -1,5 +1,13 @@
 // Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
+exports[`getPatternFlyComponentNames should return multiple organized facets: properties 1`] = `
+[
+  "componentNamesIndex",
+  "componentNamesIndexMap",
+  "byVersion",
+]
+`;
+
 exports[`getPatternFlyMcpResources should return multiple organized facets: properties 1`] = `
 [
   "availableSemVer",
@@ -26,14 +34,6 @@ exports[`getPatternFlyMcpResources should return multiple organized facets: prop
 ]
 `;
 
-exports[`getPatternFlyReactComponentNames should return multiple organized facets: properties 1`] = `
-[
-  "componentNamesIndex",
-  "componentNamesIndexMap",
-  "byVersion",
-]
-`;
-
 exports[`setCategoryDisplayLabel should normalize categories and apply linking markdown, accessibility 1`] = `"Accessibility"`;
 
 exports[`setCategoryDisplayLabel should normalize categories and apply linking markdown, design 1`] = `"Design Guidelines"`;

src/__tests__/__snapshots__/server.search.test.ts.snap

@@ -1,8 +1,15 @@
 // Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
+exports[`findClosest should attempt to find a closest match, NaN match 1`] = `
+{
+  "match": NaN,
+  "query": NaN,
+}
+`;
+
 exports[`findClosest should attempt to find a closest match, all empty string items 1`] = `
 {
-  "match": null,
+  "match": "",
   "query": "test",
 }
 `;
@@ -70,6 +77,13 @@ exports[`findClosest should attempt to find a closest match, null items 1`] = `
 }
 `;
 
+exports[`findClosest should attempt to find a closest match, null match 1`] = `
+{
+  "match": null,
+  "query": null,
+}
+`;
+
 exports[`findClosest should attempt to find a closest match, partial query 1`] = `
 {
   "match": "Button",
@@ -91,6 +105,13 @@ exports[`findClosest should attempt to find a closest match, undefined items 1`]
 }
 `;
 
+exports[`findClosest should attempt to find a closest match, undefined match 1`] = `
+{
+  "match": undefined,
+  "query": undefined,
+}
+`;
+
 exports[`findClosest should handle numbers in addition to strings, float against float query 1`] = `123.44`;
 
 exports[`findClosest should handle numbers in addition to strings, float number query 1`] = `123`;

src/__tests__/patternFly.getResources.test.ts

@@ -84,7 +84,7 @@ describe('getPatternFlyComponentSchema', () => {
   });
 });
 
-describe('getPatternFlyReactComponentNames', () => {
+describe('getPatternFlyComponentNames', () => {
   it('should return multiple organized facets', async () => {
     const result = await getPatternFlyComponentNames();
 

src/__tests__/server.search.test.ts

@@ -78,6 +78,21 @@ describe('findClosest', () => {
       description: 'all empty string items',
       query: 'test',
       items: ['', '', '']
+    },
+    {
+      description: 'undefined match',
+      query: undefined,
+      items: ['Button', 'Badge', undefined, null]
+    },
+    {
+      description: 'null match',
+      query: null,
+      items: ['Button', 'Badge', undefined, null]
+    },
+    {
+      description: 'NaN match',
+      query: NaN,
+      items: ['Button', 'Badge', NaN, null]
     }
   ])('should attempt to find a closest match, $description', ({ query, items }) => {
     expect({

src/patternFly.search.ts

@@ -94,7 +94,7 @@ interface SearchPatternFlyResults {
  * @property {Promise<PatternFlyMcpAvailableResources>} [mcpResources] - Object of multifaceted documentation entries to search.
  * @property [allowWildCardAll] - Allow a search query to match all components.
  * @property [maxDistance] - Maximum edit distance for fuzzy search.
- * @property [maxResults] - Maximum number of results to return.lts.
+ * @property [maxResults] - Maximum number of results to return.
  */
 interface SearchPatternFlyOptions {
   mcpResources?: Promise<PatternFlyMcpAvailableResources>;

src/server.search.ts

@@ -5,15 +5,16 @@ import { memo } from './server.caching';
  * normalizeString function interface
  */
 interface NormalizeString {
-  (str: string | number): string;
-  memo: (str: string | number) => string;
+  (str: unknown): string;
+  memo: (str: unknown) => string;
 }
 
 /**
  * Options for closest search
  */
 interface ClosestSearchOptions {
-  normalizeFn?: (str: string | number) => string;
+  missingReturnValue?: unknown;
+  normalizeFn?: (str: unknown) => string;
 }
 
 /**
@@ -60,15 +61,15 @@ interface FuzzySearch {
  *   - partial = 2
  *   - fuzzy = Levenshtein edit distance
  * - `maxResults` - Maximum number of results to return
- * - `normalizeFn` - Function to normalize strings (default: `normalizeString`)
+ * - `normalizeFn` - Function to normalize values (default: `normalizeString`)
  * - `isExactMatch` | `isPrefixMatch` | `isSuffixMatch` | `isContainsMatch` | `isFuzzyMatch` - Enable specific match modes
  * - `deduplicateByNormalized` - If true, deduplicate results by normalized value instead of original string (default: false)
  */
 interface FuzzySearchOptions {
   allowEmptyQuery?: boolean;
   maxDistance?: number;
   maxResults?: number;
-  normalizeFn?: (str: string | number) => string;
+  normalizeFn?: (str: unknown) => string;
   isExactMatch?: boolean;
   isPrefixMatch?: boolean;
   isSuffixMatch?: boolean;
@@ -85,10 +86,10 @@ interface FuzzySearchOptions {
  * - Can be overridden in the `findClosest` and `fuzzySearch` related options for custom normalization.
  * - Function has a `memo` property to allow use as a memoized function.
  *
- * @param str
+ * @param str - String or number to normalize.
  * @returns Normalized or empty string
  */
-const normalizeString: NormalizeString = (str: string | number) => String(str ?? '')
+const normalizeString: NormalizeString = (str: unknown) => String(str)
   .trim()
   .toLowerCase()
   .normalize('NFKD')
@@ -112,7 +113,7 @@ normalizeString.memo = memo(normalizeString, { cacheLimit: 50 });
  * @param query - Search query string or number
  * @param items - Array of strings and/or numbers to search
  * @param {ClosestSearchOptions} options - Search configuration options
- * @returns Closest matching string or number or null
+ * @returns Closest matching item from items.
  *
  * @example
  * ```typescript
@@ -121,22 +122,23 @@ normalizeString.memo = memo(normalizeString, { cacheLimit: 50 });
  * ```
  */
 const findClosest = (
-  query: string | number,
-  items: (string | number)[] = [],
+  query: unknown,
+  items: unknown[] = [],
   {
+    missingReturnValue = null,
     normalizeFn = normalizeString.memo
   }: ClosestSearchOptions = {}
 ) => {
   const normalizedQuery = normalizeFn(query);
 
-  if (!normalizedQuery || !Array.isArray(items) || items.length === 0) {
-    return null;
+  if (normalizedQuery === '' || !Array.isArray(items) || items.length === 0) {
+    return missingReturnValue;
   }
 
   const normalizedItems = items.map(item => normalizeFn(item));
   const closestMatch = closest(normalizedQuery, normalizedItems);
 
-  return items[normalizedItems.indexOf(closestMatch)] || null;
+  return items[normalizedItems.indexOf(closestMatch)];
 };
 
 /**
@@ -178,8 +180,8 @@ const findClosest = (
  * ```
  */
 const fuzzySearch = (
-  query: string | number,
-  items: (string | number)[] = [],
+  query: unknown,
+  items: unknown[] = [],
   {
     allowEmptyQuery = false,
     maxDistance = 3,