fix: review updates

Author: cdcabrera

src/__tests__/docs.json.test.ts

@@ -88,8 +88,8 @@ describe('docs.json', () => {
 
 describe('docs.json data integrity', () => {
   const allEntries = Object.values(docsJson.docs).flat();
-  const uniqueCategories = [...new Set(allEntries.map(entry => entry.category).filter(Boolean))];
-  const uniqueSections = [...new Set(allEntries.map(entry => (entry as any).section).filter(Boolean))];
+  const uniqueCategories = [...new Set(allEntries.map(entry => entry.category))];
+  const uniqueSections = [...new Set(allEntries.map(entry => entry.section))];
 
   const checkSimilarity = (list: string[], type: string) => {
     for (let i = 0; i < list.length; i++) {
@@ -113,10 +113,10 @@ describe('docs.json data integrity', () => {
   };
 
   it('should have categories that are unique and distinct', () => {
-    expect(() => checkSimilarity(uniqueCategories as string[], 'category')).not.toThrow();
+    expect(() => checkSimilarity(uniqueCategories, 'category')).not.toThrow();
   });
 
   it('should have sections that are unique and distinct', () => {
-    expect(() => checkSimilarity(uniqueSections as string[], 'section')).not.toThrow();
+    expect(() => checkSimilarity(uniqueSections, 'section')).not.toThrow();
   });
 });

src/__tests__/server.helpers.test.ts

@@ -777,7 +777,7 @@ describe('listAllCombinations', () => {
     expect(result.length).toBe(expected.length);
 
     expected.forEach(combo => {
-      expect(result).toContainEqual(expect.arrayContaining(combo));
+      expect(result).toContainEqual(combo);
     });
   });
 });

src/server.helpers.ts

@@ -205,6 +205,8 @@ const isAsync = (obj: unknown) => /^\[object (Async|AsyncFunction)]/.test(Object
 /**
  * Check if "is a Promise", "Promise like".
  *
+ * @note This is an internal intentional stable classifier, not a general "returns a thenable" check.
+ *
  * @param obj - Object, or otherwise, to check
  * @returns `true` if the object is a Promise
  */

src/server.resourceMeta.ts

@@ -191,7 +191,7 @@ const setMetadataOptions = ({ name, baseUri, searchParams, metaConfig, config, c
       return generateMetaContent({
         title: metaTitle,
         description: metaDescription,
-        params: params || [],
+        params: params,
         exampleUris
       });
     };