fix: review update

Author: cdcabrera

src/__tests__/__snapshots__/options.defaults.test.ts.snap

@@ -68,15 +68,15 @@ exports[`options defaults should return specific properties: defaults 1`] = `
         "@patternfly/patternfly",
       ],
     },
-    "urlWhiteListProtocols": [
-      "http",
-      "https",
-    ],
     "urlWhitelist": [
       "https://patternfly.org",
       "https://github.com/patternfly",
       "https://raw.githubusercontent.com/patternfly",
     ],
+    "urlWhitelistProtocols": [
+      "http",
+      "https",
+    ],
   },
   "pluginHost": {
     "gracePeriodMs": 2000,

src/options.context.ts

@@ -86,7 +86,7 @@ const optionsContext = new AsyncLocalStorage<GlobalOptions>();
 const setOptions = (options?: DefaultOptionsOverrides): GlobalOptions => {
   const base = mergeObjects(DEFAULT_OPTIONS, options, { allowNullValues: false, allowUndefinedValues: false });
 
-  assertProtocol(base.patternflyOptions.urlWhitelist, base.patternflyOptions.urlWhiteListProtocols);
+  assertProtocol(base.patternflyOptions.urlWhitelist, base.patternflyOptions.urlWhitelistProtocols);
 
   const baseLogging = isPlainObject(base.logging) ? base.logging : DEFAULT_OPTIONS.logging;
   const basePluginIsolation = ['strict', 'none'].includes(base.pluginIsolation) ? base.pluginIsolation : DEFAULT_OPTIONS.pluginIsolation;

src/options.defaults.ts

@@ -188,7 +188,7 @@ type WhitelistUrl = `${'http' | 'https'}://${string}`;
  *    - 'highest': Use the highest major version found.
  *    - 'lowest': Use the lowest major version found.
  * @property {WhitelistUrl[]} urlWhitelist List of allowed URLs to fetch PatternFly resources from.
- * @property urlWhiteListProtocols List of allowed URL protocols to validate against when fetching PatternFly resources.
+ * @property urlWhitelistProtocols List of allowed URL protocols to validate against when fetching PatternFly resources.
  */
 interface PatternFlyOptions {
   availableResourceVersions: ('6.0.0')[];
@@ -202,7 +202,7 @@ interface PatternFlyOptions {
     versionStrategy: 'highest' | 'lowest';
   },
   urlWhitelist: WhitelistUrl[];
-  urlWhiteListProtocols: string[];
+  urlWhitelistProtocols: string[];
 }
 
 /**
@@ -439,7 +439,7 @@ const PATTERNFLY_OPTIONS: PatternFlyOptions = {
     'https://github.com/patternfly',
     'https://raw.githubusercontent.com/patternfly'
   ],
-  urlWhiteListProtocols: ['http', 'https']
+  urlWhitelistProtocols: ['http', 'https']
 };
 
 /**

src/server.assertions.ts

@@ -151,7 +151,7 @@ function assertInputStringNumberEnumLike(
 function assertInputUrlWhiteListed(
   input: unknown,
   whitelist: WhitelistUrl[],
-  { allowedProtocols = DEFAULT_OPTIONS.patternflyOptions.urlWhiteListProtocols, inputDisplayName, message, urlDisplayMaxLength = 50 }: {
+  { allowedProtocols = DEFAULT_OPTIONS.patternflyOptions.urlWhitelistProtocols, inputDisplayName, message, urlDisplayMaxLength = 50 }: {
     allowedProtocols?: string[]; inputDisplayName?: string; message?: string; urlDisplayMaxLength?: number
   } = {}
 ): asserts input is string | string[] {