Skip to content

Commit 087fd4b

Browse files
author
Eric Olkowski
committed
chore(Upgrade guide): removed verbiage on button aria-disabled
1 parent d8246f5 commit 087fd4b

File tree

1 file changed

+0
-2
lines changed
  • packages/documentation-site/patternfly-docs/content/get-started

1 file changed

+0
-2
lines changed

packages/documentation-site/patternfly-docs/content/get-started/upgrade.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,6 @@ If you have previously implemented any breakpoint logic based on a pixel value,
114114

115115
There are a few test failures that you're likely to encounter:
116116

117-
1. **Button:** Cannot find `aria-disabled`
118-
- We changed button's `isDisabled` prop to assign a value for `disabled`, but none for `aria-disabled`. As a result, any test that looks for `aria-disabled` may fail.
119117
1. **Button:** Cannot find button attributes when using `byText`
120118
- There's a new wrapping `div` around text in buttons. The RTL `byText` query returns that wrapper instead of the button element itself, which is where button's attributes live. Instead of `byText`, use `byRole` and pass the button text to `name`. This will return the top-level button element.
121119
1. **Select (when using React Testing Library):** Cannot find `role`

0 commit comments

Comments
 (0)