Skip to content

Commit b075f66

Browse files
author
Eric Olkowski
committed
Updated verbiage for ariadisabled being conditionally rendered
1 parent 6c8abbb commit b075f66

File tree

1 file changed

+2
-2
lines changed
  • packages/documentation-site/patternfly-docs/content/get-started

1 file changed

+2
-2
lines changed

packages/documentation-site/patternfly-docs/content/get-started/upgrade.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,8 @@ If you have previously implemented any breakpoint logic based on a pixel value,
172172
#### Button
173173

174174
1. *Cannot find aria-disabled*
175-
- **Cause:** We changed the `isDisabled` prop to assign a value for `disabled`, but none for `aria-disabled`.
176-
- **Fix:** Remove tests that look for `aria-disabled` in buttons.
175+
- **Cause:** We changed button's `isDisabled` prop to assign a value for `disabled`, but none for `aria-disabled` - except for when the `component` prop is passed anything other than "button" as a value. Additionally, `aria-disabled` will now only render when true.
176+
- **Fix:** Remove tests that look for `aria-disabled` in buttons when the expectation is for it to be false, or to match `isDisabled` when `component="button"`.
177177

178178
1. *Cannot find button attributes when using byText*
179179
- **Cause:** We added a wrapping `div` around button text. The RTL `byText` query returns that wrapper instead of the button element itself, where button's attributes live.

0 commit comments

Comments
 (0)