docs(dual list selector): v6 design guidelines image updates#4598
Conversation
kaylachumley
requested review from
andrew-ronaldson,
bekah-stephens and
nicolethoen
kaylachumley
changed the title
There was a problem hiding this comment.
In other guidelines where there's a sequence of events, the number on the screenshot matches the sequence number, and they're shown in that order. Because there are several callouts for the On Drag example, though, I think the numbered annotations are a bit confusing, especially because there are multiple #1s. Maybe @edonehoo can weigh in on the best way to handle this?
There was a problem hiding this comment.
I agree! i think the numbered annotations need removed from this section
There was a problem hiding this comment.
or I think if you swap the order so that the pictures come before the numbered descriptions in the content it would be the most helpful potentially
Like
[first image in the sequence]
- onDrag event ...
[second image] -- remove the "1" annotation
2. Ghost row...
[third image] -- change the annotation # in this image to be "3"
3. postDrag event ...
Does this make sense?
There was a problem hiding this comment.
Maybe leaving the images after the text would be fine too as long as you change the annotations in the second and third images
bekah-stephens
left a comment
bekah-stephens
left a comment
There was a problem hiding this comment.
I left a comment on the On Drag and Post Drag section - just some food for thought
|
pushed the newest updates based on your comments above! @edonehoo @bekah-stephens |
5 participants
close #4523