-
Notifications
You must be signed in to change notification settings - Fork 148
chore(file upload): img updates #4604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrew-ronaldson
merged 2 commits into
patternfly:main
from
andrew-ronaldson:file-upload
May 8, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-157 KB
...ontent/design-guidelines/components/file-upload-multiple/img/best-practices.png
Binary file not shown.
176 changes: 176 additions & 0 deletions
176
...ontent/design-guidelines/components/file-upload-multiple/img/best-practices.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-80.8 KB
...docs/content/design-guidelines/components/file-upload-multiple/img/elements.png
Binary file not shown.
75 changes: 75 additions & 0 deletions
75
...docs/content/design-guidelines/components/file-upload-multiple/img/elements.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-153 KB
...ontent/design-guidelines/components/file-upload-multiple/img/loading-states.png
Binary file not shown.
163 changes: 163 additions & 0 deletions
163
...ontent/design-guidelines/components/file-upload-multiple/img/loading-states.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
179 changes: 179 additions & 0 deletions
179
...nt/design-guidelines/components/file-upload-multiple/img/multi-upload-usage.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-105 KB
...ent/design-guidelines/components/file-upload-multiple/img/upload-via-button.png
Binary file not shown.
126 changes: 126 additions & 0 deletions
126
...ent/design-guidelines/components/file-upload-multiple/img/upload-via-button.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
135 changes: 135 additions & 0 deletions
135
.../design-guidelines/components/file-upload-multiple/img/upload-via-drag-drop.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-164 KB
...cs/content/design-guidelines/components/file-upload-multiple/img/validation.png
Binary file not shown.
166 changes: 166 additions & 0 deletions
166
...cs/content/design-guidelines/components/file-upload-multiple/img/validation.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
25 changes: 25 additions & 0 deletions
25
...patternfly-docs/content/design-guidelines/components/file-upload/Fileupload.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 19 additions & 0 deletions
19
...te/patternfly-docs/content/design-guidelines/components/file-upload/Loading.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-37.5 KB
...ternfly-docs/content/design-guidelines/components/file-upload/img/FileError.png
Binary file not shown.
22 changes: 22 additions & 0 deletions
22
...ternfly-docs/content/design-guidelines/components/file-upload/img/FileError.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-30.7 KB
...ernfly-docs/content/design-guidelines/components/file-upload/img/Fileupload.png
Binary file not shown.
24 changes: 24 additions & 0 deletions
24
...ernfly-docs/content/design-guidelines/components/file-upload/img/Fileupload.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-26.5 KB
...atternfly-docs/content/design-guidelines/components/file-upload/img/Loading.png
Binary file not shown.
18 changes: 18 additions & 0 deletions
18
...atternfly-docs/content/design-guidelines/components/file-upload/img/Loading.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-57.8 KB
...rnfly-docs/content/design-guidelines/components/file-upload/img/Noneditable.png
Binary file not shown.
19 changes: 19 additions & 0 deletions
19
...rnfly-docs/content/design-guidelines/components/file-upload/img/Noneditable.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-58.2 KB
...tternfly-docs/content/design-guidelines/components/file-upload/img/editable.png
Binary file not shown.
19 changes: 19 additions & 0 deletions
19
...tternfly-docs/content/design-guidelines/components/file-upload/img/editable.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small comments:
(1) the input field should be the default state here, not read-only
(2) it might not matter, but this image and the loading state image both don't have backgrounds (the others do, so I just thought I'd point it out)