Skip to content

fix(quickstarts): restructure components to correct spacing and remove divider below toolbar #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 1 commit into from
Apr 2, 2025
Merged

fix(quickstarts): restructure components to correct spacing and remove divider below toolbar #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 31 additions & 18 deletions packages/dev/src/AppCustomDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import './App.css';
import {
Page,
PageSection,
Button,
Drawer,
DrawerContent,
Expand All @@ -11,6 +12,8 @@ import {
DrawerPanelDescription,
DrawerPanelBody,
DrawerContentBody,
Stack,
StackItem,
} from '@patternfly/react-core';
import {
LoadingBox,
Expand Down Expand Up @@ -140,24 +143,34 @@ const App: React.FC<AppProps> = ({ children, showCardFooters }) => {
>
<DrawerContentBody>
<Page masthead={AppHeader} sidebar={AppSidebar} isManagedSidebar>
<Button
variant="secondary"
onClick={() => {
toggleQuickStart('getting-started-with-quick-starts');
setDrawerContent('quickstart');
}}
>
Getting started with quick starts
</Button>
<Button
variant="secondary"
onClick={() => {
setActiveQuickStartID('');
setDrawerContent('custom');
}}
>
Open a different drawer
</Button>
<PageSection>
<Stack hasGutter>
<StackItem>
<Button
variant="secondary"
isBlock
onClick={() => {
toggleQuickStart('getting-started-with-quick-starts');
setDrawerContent('quickstart');
}}
>
Getting started with quick starts
</Button>
</StackItem>
<StackItem>
<Button
variant="secondary"
isBlock
onClick={() => {
setActiveQuickStartID('');
setDrawerContent('custom');
}}
>
Open a different drawer
</Button>
</StackItem>
</Stack>
</PageSection>
{children}
</Page>
</DrawerContentBody>
Expand Down
17 changes: 10 additions & 7 deletions packages/dev/src/AppProps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import './App.css';
import { Page, Button } from '@patternfly/react-core';
import { Page, Button, PageSection } from '@patternfly/react-core';
import {
LoadingBox,
QuickStartContainer,
Expand Down Expand Up @@ -80,12 +80,15 @@ const App: React.FC<AppProps> = ({ children, showCardFooters }) => {
<React.Suspense fallback={<LoadingBox />}>
<QuickStartContainer {...drawerProps}>
<Page masthead={AppHeader} sidebar={AppSidebar} isManagedSidebar>
<Button
variant="secondary"
onClick={() => toggleQuickStart('getting-started-with-quick-starts')}
>
Getting started with quick starts
</Button>
<PageSection>
<Button
variant="secondary"
isBlock
onClick={() => toggleQuickStart('getting-started-with-quick-starts')}
>
Getting started with quick starts
</Button>
</PageSection>
{children}
</Page>
</QuickStartContainer>
Expand Down
7 changes: 5 additions & 2 deletions packages/dev/src/CustomCatalog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,17 +238,20 @@ export const CustomCatalog: React.FC = () => {

return (
<>
<PageSection hasBodyWrapper={false}>
<PageSection>
<QuickStartCatalogHeader title="Resources" />
</PageSection>
<PageSection>
<Divider component="div" />
</PageSection>
<PageSection>
<QuickStartCatalogToolbar>
<ToolbarContent>
<QuickStartCatalogFilterSearchWrapper onSearchInputChange={onSearchInputChange} />
<QuickStartCatalogFilterStatusWrapper onStatusChange={onStatusChange} />
<QuickStartCatalogFilterCountWrapper quickStartsCount={filteredQuickStarts.length} />
</ToolbarContent>
</QuickStartCatalogToolbar>
<Divider component="div" />
</PageSection>
<PageSection hasBodyWrapper={false}>{quickStartCatalog()}</PageSection>
</>
Expand Down
1 change: 0 additions & 1 deletion packages/module/src/QuickStartCatalogPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ export const QuickStartCatalogPage: React.FC<QuickStartCatalogPageProps> = ({
onSearchInputChange={onSearchInputChange}
onStatusChange={onStatusChange}
/>
<Divider component="div" />
</>
)}
</PageSection>
Expand Down