fix(package.json): Add React 17 as peer dependency#386
Merged
dlabaj merged 2 commits intopatternfly:mainfrom Apr 10, 2025
Merged
fix(package.json): Add React 17 as peer dependency#386dlabaj merged 2 commits intopatternfly:mainfrom
dlabaj merged 2 commits intopatternfly:mainfrom
Conversation
✅ Deploy Preview for quickstarts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
logonoff
reviewed
Apr 9, 2025
Member
logonoff
left a comment
logonoff
left a comment
There was a problem hiding this comment.
I think the changes need to be made in this file:
https://github.com/patternfly/patternfly-quickstarts/blob/main/packages/module/package.json
logonoff
reviewed
Apr 9, 2025
| "@patternfly/react-core": "^6.0.0", | ||
| "react": ">=18.0.0", | ||
| "react": "17.0.0 || >=18.0.0", | ||
| "react-dom": ">=18.0.0", |
Member
There was a problem hiding this comment.
Suggested change
| "react-dom": ">=18.0.0", | |
| "react-dom": "^17 || ^18", |
Co-authored-by: logonoff <git@logonoff.co>
dlabaj
approved these changes
Apr 9, 2025
|
🎉 This PR is included in version 6.3.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added peer dependency - unsure if anything else is needed, but let me know.