Skip to content

fix(Nav): added role presentation to NavItemSeparator #2300

fix(Nav): added role presentation to NavItemSeparator

fix(Nav): added role presentation to NavItemSeparator #2300

Triggered via pull request March 31, 2025 19:13
Status Failure
Total duration 1m 15s
Artifacts

main.yml

on: pull_request
Build demo app
0s
Build demo app
Unit tests
0s
Unit tests
Matrix: Integration tests
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
Build
Process completed with exit code 2.
Build: packages/react-core/src/components/Toolbar/ToolbarItem.tsx#L191
Type '{ accept?: string; acceptCharset?: string; action?: string; allowFullScreen?: boolean; allowTransparency?: boolean; alt?: string; as?: string; async?: boolean; autoComplete?: string; autoPlay?: boolean; ... 356 more ...; orientation: { ...; }; }' is not assignable to type 'DividerProps'.
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L227
React Hook useImperativeHandle has an unnecessary dependency: 'selectOpen'. Either exclude it or remove the dependency array
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L161
React Hook useEffect has missing dependencies: 'applyValidators', 'dateIsRequired', 'dateParse', 'emptyDateText', 'errorText', 'pristine', and 'textInputFocused'. Either include them or remove the dependency array. If 'dateParse' changes too often, find the parent component that defines it and wrap that definition in useCallback
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L150
React Hook useEffect has missing dependencies: 'applyValidators' and 'valueDate'. Either include them or remove the dependency array
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L144
React Hook useEffect has a missing dependency: 'dateParse'. Either include it or remove the dependency array. If 'dateParse' changes too often, find the parent component that defines it and wrap that definition in useCallback
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L133
React Hook useMemo has a missing dependency: 'placeholder.length'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/Card/examples/CardWithModifiers.tsx#L18
Mutating a value returned from 'useState()', which should not be mutated. Use the setter function to update instead
Lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L191
React Hook useEffect has a missing dependency: 'shouldFocus'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L184
React Hook useEffect has a missing dependency: 'focusedDate'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/BackToTop/BackToTop.tsx#L36
The 'toggleVisible' function makes the dependencies of useEffect Hook (at line 74) change on every render. Move it inside the useEffect callback. Alternatively, wrap the definition of 'toggleVisible' in its own useCallback() Hook
Lint: packages/react-core/src/components/Alert/Alert.tsx#L167
React Hook useEffect has missing dependencies: 'hasAnimations', 'offstageRight', and 'updateTransitionEnd'. Either include them or remove the dependency array