Skip to content

Commit 0373c15

Browse files
committed
feat(CC-batch-5): group review 4 followup
1 parent 57a9628 commit 0373c15

File tree

3 files changed

+37
-29
lines changed

3 files changed

+37
-29
lines changed
Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,7 @@
11
import figma from '@figma/code-connect';
2-
import { CalendarMonth, CalendarMonthInlineProps, Title } from '@patternfly/react-core';
2+
import { CalendarMonth, Title } from '@patternfly/react-core';
33

44
// Documentation for CalendarMonth can be found at https://www.patternfly.org/components/calendar-month
5-
const inlineProps: CalendarMonthInlineProps = {
6-
component: 'article',
7-
title: (
8-
<Title headingLevel="h4" id="favorite-date">
9-
Select your favorite date
10-
</Title>
11-
),
12-
ariaLabelledby: 'favorite-date'
13-
};
145

156
figma.connect(
167
CalendarMonth,
@@ -20,7 +11,12 @@ figma.connect(
2011
date: '2025-06-16'
2112
},
2213
example: (props) => (
23-
<CalendarMonth date={props.date} inlineProps={inlineProps} onChange={() => {}} onMonthChange={() => {}} />
14+
<CalendarMonth
15+
date={props.date}
16+
inlineProps={{ component: 'article', ariaLabelledby: 'favorite-date' }}
17+
onChange={() => {}}
18+
onMonthChange={() => {}}
19+
/>
2420
)
2521
}
2622
);
@@ -31,17 +27,22 @@ figma.connect(
3127
{
3228
variant: { Type: 'With date range' },
3329
props: {
34-
startDate: new Date(2020, 10, 11),
35-
endDate: new Date(2020, 10, 24)
30+
rangeStart: new Date(2020, 10, 11),
31+
date: new Date(2020, 10, 24)
3632
},
3733
example: (props) => (
38-
<CalendarMonth
39-
date={props.startDate}
40-
inlineProps={inlineProps}
41-
onChange={() => {}}
42-
onMonthChange={() => {}}
43-
rangeStart={props.endDate}
44-
/>
34+
<>
35+
<Title headingLevel="h4" id="favorite-date">
36+
Select your favorite date
37+
</Title>
38+
<CalendarMonth
39+
date={props.date}
40+
inlineProps={{ component: 'article', ariaLabelledby: 'favorite-date' }}
41+
onChange={() => {}}
42+
onMonthChange={() => {}}
43+
rangeStart={props.rangeStart}
44+
/>
45+
</>
4546
)
4647
}
4748
);

packages/code-connect/components/DatePicker/TimePicker.figma.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,9 @@ figma.connect(
88
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=7958-136830',
99
{
1010
props: {
11-
isDisabled: figma.enum('State', { Disabled: true }),
12-
isOpen: figma.enum('State', { Open: true })
11+
isDisabled: figma.enum('State', { Disabled: true })
1312
},
14-
example: (props) => (
15-
<TimePicker isDisabled={props.isDisabled} isOpen={props.isOpen} onChange={() => {}} time="3:35 AM" />
16-
)
13+
example: (props) => <TimePicker isDisabled={props.isDisabled} onChange={() => {}} time="3:35 AM" />
1714
}
1815
);
1916

@@ -22,6 +19,6 @@ figma.connect(
2219
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=7958-136830',
2320
{
2421
variant: { State: 'Invalid' },
25-
example: () => <TimePicker is24Hour minTime="9:30" maxTime="17:15" placeholder="14:00" />
22+
example: () => <TimePicker is24Hour minTime="9:30" maxTime="17:15" time="18:00" />
2623
}
2724
);

packages/code-connect/components/EmptyState/EmptyState.figma.tsx

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import figma from '@figma/code-connect';
2-
import { EmptyState, EmptyStateBody, EmptyStateFooter, EmptyStateActions } from '@patternfly/react-core';
2+
import { EmptyState, EmptyStateBody, EmptyStateFooter, EmptyStateActions, Button } from '@patternfly/react-core';
33
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
44

55
// TODO: DESIGN: Add Empty state footer
@@ -32,7 +32,7 @@ figma.connect(
3232
Info: 'info'
3333
}),
3434
variant: figma.enum('Size', {
35-
Basic: undefined,
35+
Basic: 'full',
3636
'Extra small': 'xs',
3737
Small: 'sm',
3838
Large: 'lg',
@@ -52,7 +52,17 @@ figma.connect(
5252
>
5353
<EmptyStateBody>{props.body}</EmptyStateBody>
5454
<EmptyStateFooter>
55-
<EmptyStateActions>{props.actions}</EmptyStateActions>
55+
<EmptyStateActions>
56+
<Button variant="primary">Primary action</Button>
57+
</EmptyStateActions>
58+
<EmptyStateActions>
59+
<Button variant="link">Multiple</Button>
60+
<Button variant="link">Action Buttons</Button>
61+
<Button variant="link">Can</Button>
62+
<Button variant="link">Go here</Button>
63+
<Button variant="link">In the secondary</Button>
64+
<Button variant="link">Action area</Button>
65+
</EmptyStateActions>
5666
</EmptyStateFooter>
5767
</EmptyState>
5868
)

0 commit comments

Comments
 (0)