Skip to content

Commit 0d2c20a

Browse files
committed
Chore(DescriptionList): added unique aria-labels
1 parent eeb1714 commit 0d2c20a

27 files changed

+73
-24
lines changed

packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitBasic.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListAutoFitBasic: React.FunctionComponent = () => (
12-
<DescriptionList isAutoFit>
12+
<DescriptionList isAutoFit aria-label="Basic auto-fit">
1313
<DescriptionListGroup>
1414
<DescriptionListTerm>Name</DescriptionListTerm>
1515
<DescriptionListDescription>example</DescriptionListDescription>

packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthModified.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListAutoFitMinWidthModified: React.FunctionComponent = () => (
12-
<DescriptionList isAutoFit autoFitMinModifier={{ default: '200px' }}>
12+
<DescriptionList
13+
isAutoFit
14+
autoFitMinModifier={{ default: '200px' }}
15+
aria-label="Auto-fit grid with minimum width modification"
16+
>
1317
<DescriptionListGroup>
1418
<DescriptionListTerm>Name</DescriptionListTerm>
1519
<DescriptionListDescription>example</DescriptionListDescription>

packages/react-core/src/components/DescriptionList/examples/DescriptionListAutoFitMinWidthResponsive.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListAutoFitMinWidthResponsive: React.FunctionComponent = () => (
12-
<DescriptionList isAutoFit autoFitMinModifier={{ md: '100px', lg: '150px', xl: '200px', '2xl': '300px' }}>
12+
<DescriptionList
13+
isAutoFit
14+
autoFitMinModifier={{ md: '100px', lg: '150px', xl: '200px', '2xl': '300px' }}
15+
aria-label="Responsive auto-fit grid with minimum width"
16+
>
1317
<DescriptionListGroup>
1418
<DescriptionListTerm>Name</DescriptionListTerm>
1519
<DescriptionListDescription>example</DescriptionListDescription>

packages/react-core/src/components/DescriptionList/examples/DescriptionListBasic.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListBasic: React.FunctionComponent = () => (
12-
<DescriptionList>
12+
<DescriptionList aria-label="Basic description list">
1313
<DescriptionListGroup>
1414
<DescriptionListTerm>Name</DescriptionListTerm>
1515
<DescriptionListDescription>Example</DescriptionListDescription>

packages/react-core/src/components/DescriptionList/examples/DescriptionListColumnFill.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListColumnFill: React.FunctionComponent = () => (
12-
<DescriptionList isFillColumns columnModifier={{ default: '2Col', lg: '3Col' }}>
12+
<DescriptionList
13+
isFillColumns
14+
columnModifier={{ default: '2Col', lg: '3Col' }}
15+
aria-label="Description list with column fill enabled"
16+
>
1317
<DescriptionListGroup>
1418
<DescriptionListTerm>Name</DescriptionListTerm>
1519
<DescriptionListDescription>

packages/react-core/src/components/DescriptionList/examples/DescriptionListCompact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListCompact: React.FunctionComponent = () => (
12-
<DescriptionList isCompact>
12+
<DescriptionList isCompact aria-label="Compact description list">
1313
<DescriptionListGroup>
1414
<DescriptionListTerm>Name</DescriptionListTerm>
1515
<DescriptionListDescription>Example</DescriptionListDescription>

packages/react-core/src/components/DescriptionList/examples/DescriptionListCompactHorizontal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListCompactHorizontal: React.FunctionComponent = () => (
12-
<DescriptionList isCompact isHorizontal>
12+
<DescriptionList isCompact isHorizontal aria-label="Compact horizontal description list">
1313
<DescriptionListGroup>
1414
<DescriptionListTerm>Name</DescriptionListTerm>
1515
<DescriptionListDescription>Example</DescriptionListDescription>

packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultAutoColumn.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListDefaultAutoColumn: React.FunctionComponent = () => (
12-
<DescriptionList isAutoColumnWidths columnModifier={{ default: '3Col' }}>
12+
<DescriptionList isAutoColumnWidths columnModifier={{ default: '3Col' }} aria-label="Default auto column width">
1313
<DescriptionListGroup>
1414
<DescriptionListTerm>Name</DescriptionListTerm>
1515
<DescriptionListDescription>Example</DescriptionListDescription>

packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultInlineGrid.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListDefaultInlineGrid: React.FunctionComponent = () => (
12-
<DescriptionList columnModifier={{ default: '3Col' }} isInlineGrid>
12+
<DescriptionList columnModifier={{ default: '3Col' }} isInlineGrid aria-label="Default inline grid">
1313
<DescriptionListGroup>
1414
<DescriptionListTerm>Name</DescriptionListTerm>
1515
<DescriptionListDescription>Example</DescriptionListDescription>

packages/react-core/src/components/DescriptionList/examples/DescriptionListDefaultResponsiveColumns.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@ import {
99
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
1010

1111
export const DescriptionListDefaultResponsiveColumns: React.FunctionComponent = () => (
12-
<DescriptionList columnModifier={{ lg: '2Col', xl: '3Col' }}>
12+
<DescriptionList
13+
columnModifier={{ lg: '2Col', xl: '3Col' }}
14+
aria-label="Default responsive columns based on screen size"
15+
>
1316
<DescriptionListGroup>
1417
<DescriptionListTerm>Name</DescriptionListTerm>
1518
<DescriptionListDescription>Example</DescriptionListDescription>

0 commit comments

Comments
 (0)