Skip to content

Commit 31f0e13

Browse files
committed
fix(bug): added tabContentId to resolve accessibility issue
1 parent 469bb15 commit 31f0e13

3 files changed

Lines changed: 237 additions & 27 deletions

File tree

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@
124124
"dependencies": {
125125
"@patternfly/react-component-groups": "^6.2.1",
126126
"clsx": "^2.1.1",
127-
"react-jss": "^10.10.0"
127+
"react-jss": "^10.10.0",
128+
"serve": "^14.2.4"
128129
}
129130
}

packages/react-core/src/demos/Animations/examples/Animations.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1555,22 +1555,22 @@ export const Animations: FunctionComponent = () => {
15551555
<Content component={ContentVariants.h1}>Resources</Content>
15561556
<Content className="pf-v6-u-mb-md">Everything you need to know about your application</Content>
15571557
<Tabs activeKey={selectedTab} onSelect={(_e, key) => setSelectedTab(Number(key))} aria-label="Primary tabs">
1558-
<Tab eventKey={0} title={<TabTitleText>Overview</TabTitleText>} />
1559-
<Tab eventKey={1} title={<TabTitleText>Resources</TabTitleText>} />
1560-
<Tab eventKey={2} title={<TabTitleText>Database</TabTitleText>} />
1558+
<Tab eventKey={0} title={<TabTitleText>Overview</TabTitleText>} tabContentId="overview" />
1559+
<Tab eventKey={1} title={<TabTitleText>Resources</TabTitleText>} tabContentId="resources" />
1560+
<Tab eventKey={2} title={<TabTitleText>Database</TabTitleText>} tabContentId="database" />
15611561
</Tabs>
15621562
</PageSection>
15631563
{selectedTab === 0 && (
15641564
<Fragment>
1565-
<PageSection>
1565+
<PageSection id="overview">
15661566
<MultiContentCard isExpandable={true} cards={cards} toggleText="Improve recommended pathways" />
15671567
</PageSection>
15681568
<PageSection aria-label="Detail status events">{detailStatusEvents}</PageSection>
15691569
</Fragment>
15701570
)}
15711571

15721572
{selectedTab === 1 && (
1573-
<PageSection>
1573+
<PageSection id="resources">
15741574
<TableExpandCollapseAll />
15751575
</PageSection>
15761576
)}

0 commit comments

Comments
 (0)