Reverted role prop type to union

Author: Eric Olkowski

packages/react-core/src/components/Divider/Divider.tsx

@@ -32,7 +32,7 @@ export interface DividerProps extends React.HTMLProps<HTMLElement> {
     '2xl'?: 'vertical' | 'horizontal';
   };
   /** The ARIA role of the divider when the component property has a value other than "hr". */
-  role?: string;
+  role?: 'separator' | 'presentation';
 }
 
 export const Divider: React.FunctionComponent<DividerProps> = ({

packages/react-core/src/components/Toolbar/ToolbarItem.tsx

@@ -185,12 +185,19 @@ export const ToolbarItem: React.FunctionComponent<ToolbarItemProps> = ({
   children,
   isAllExpanded,
   isOverflowContainer,
+  role,
   ...props
 }: ToolbarItemProps) => {
   if (variant === ToolbarItemVariant.separator) {
-    // TODO: consider removing spread props here so we can update Divider role prop to union of
-    // separator or presentation rather than generic string
-    return <Divider className={css(className)} orientation={{ default: 'vertical' }} {...props} />;
+    const isDividerRoleValid = role === 'separator' || role === 'presentation';
+    return (
+      <Divider
+        className={css(className)}
+        orientation={{ default: 'vertical' }}
+        {...props}
+        {...(isDividerRoleValid && { role: role as 'separator' | 'presentation' })}
+      />
+    );
   }
 
   return (
@@ -219,6 +226,7 @@ export const ToolbarItem: React.FunctionComponent<ToolbarItemProps> = ({
           )}
           {...(variant === 'label' && { 'aria-hidden': true })}
           id={id}
+          role={role}
           {...props}
         >
           {children}