Skip to content

Commit 545c346

Browse files
mattnoltingmattnolting
committed
feat(CC-batch-7): group review 9/23 updates
1 parent 38e6df3 commit 545c346

File tree

9 files changed

+45
-33
lines changed

9 files changed

+45
-33
lines changed

‎packages/code-connect/components/NotificationDrawer/NotificationDrawer.figma.tsx‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,43 +6,47 @@ import {
66
NotificationDrawerList
77
} from '@patternfly/react-core';
88

9+
// Documentation for NotificationDrawer can be found at https://www.patternfly.org/components/notification-drawer
10+
11+
// Default
912
figma.connect(
1013
NotificationDrawer,
11-
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components?node-id=7172-99015',
14+
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=7172-99015',
1215
{
13-
variant: { Type: 'Grouped' },
1416
props: {
1517
// children
1618
notificationDrawerHeader: figma.children('Notification drawer header'),
17-
notificationDrawerGroup: figma.children('Notification drawer groups')
19+
notificationDrawerItems: figma.children(['Notifications', 'Notification drawer item'])
1820
},
1921
example: (props) => (
2022
// Documentation for NotificationDrawer can be found at https://www.patternfly.org/components/notification-drawer
2123
<NotificationDrawer>
2224
{props.notificationDrawerHeader}
2325
<NotificationDrawerBody>
24-
<NotificationDrawerGroupList>{props.notificationDrawerGroup}</NotificationDrawerGroupList>
26+
<NotificationDrawerList>{props.notificationDrawerItems}</NotificationDrawerList>
2527
</NotificationDrawerBody>
2628
</NotificationDrawer>
2729
)
2830
}
2931
);
3032

33+
// Grouped
3134
figma.connect(
3235
NotificationDrawer,
33-
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components?node-id=7172-99015',
36+
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=7172-99015',
3437
{
38+
variant: { Type: 'Grouped' },
3539
props: {
3640
// children
3741
notificationDrawerHeader: figma.children('Notification drawer header'),
38-
notificationDrawerItems: figma.children(['Notifications', 'Notification drawer item'])
42+
notificationDrawerGroup: figma.children('Notification drawer groups')
3943
},
4044
example: (props) => (
4145
// Documentation for NotificationDrawer can be found at https://www.patternfly.org/components/notification-drawer
4246
<NotificationDrawer>
4347
{props.notificationDrawerHeader}
4448
<NotificationDrawerBody>
45-
<NotificationDrawerList>{props.notificationDrawerItems}</NotificationDrawerList>
49+
<NotificationDrawerGroupList>{props.notificationDrawerGroup}</NotificationDrawerGroupList>
4650
</NotificationDrawerBody>
4751
</NotificationDrawer>
4852
)

‎packages/code-connect/components/NotificationDrawer/NotificationDrawerGroups.figma.tsx‎

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,33 @@ figma.connect(
88
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=3172-18190',
99
{
1010
props: {
11+
// string
12+
headingText: figma.string('Group title'),
13+
count: 3,
14+
1115
// boolean
12-
hasCount: figma.boolean('Has count', {
13-
true: figma.string('Text'),
14-
false: 0
16+
badgeProps: figma.boolean('Has count', {
17+
true: figma.nestedProps('Badge', {
18+
count: figma.string('Text')
19+
}),
20+
false: { count: undefined }
1521
}),
1622

1723
// enum
18-
headingText: figma.string('Group title'),
19-
20-
// string
2124
isExpanded: figma.enum('Type', {
2225
Collapsed: false,
2326
Expanded: true
2427
}),
2528

26-
children: figma.children('*')
29+
children: figma.children('Notification drawer item')
2730
},
2831
example: (props) => (
29-
<NotificationDrawerGroup isExpanded={props.isExpanded} count={props.hasCount} title={props.headingText}>
32+
<NotificationDrawerGroup
33+
title={props.headingText}
34+
isExpanded={props.isExpanded}
35+
count={props.badgeProps.count}
36+
onExpand={() => {}}
37+
>
3038
<NotificationDrawerList>{props.children}</NotificationDrawerList>
3139
</NotificationDrawerGroup>
3240
)

‎packages/code-connect/components/NotificationDrawer/NotificationDrawerItem.figma.tsx‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,17 @@ import {
66
MenuToggle,
77
NotificationDrawerListItem,
88
NotificationDrawerListItemBody,
9-
NotificationDrawerListItemHeader,
10-
Timestamp
9+
NotificationDrawerListItemHeader
1110
} from '@patternfly/react-core';
1211
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
1312

1413
// Documentation for NotificationDrawerListItem can be found at https://www.patternfly.org/components/notification-drawer
1514

1615
figma.connect(
1716
NotificationDrawerListItem,
18-
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components?node-id=3164-16861',
17+
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=3164-16861',
1918
{
2019
props: {
21-
timestamp: <Timestamp date={new Date()} />,
22-
2320
// enum
2421
isRead: figma.enum('Type', { Read: true }),
2522
isHoverable: figma.enum('State', { Hover: true }),
@@ -62,7 +59,7 @@ figma.connect(
6259
</DropdownList>
6360
</Dropdown>
6461
</NotificationDrawerListItemHeader>
65-
<NotificationDrawerListItemBody timestamp={props.timestamp}>
62+
<NotificationDrawerListItemBody timestamp="5 minutes ago">
6663
{props.alertDescription}
6764
</NotificationDrawerListItemBody>
6865
</NotificationDrawerListItem>

‎packages/code-connect/components/PopOver/Popover.figma.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ figma.connect(
1818
props: {
1919
// boolean
2020
footerContent: figma.boolean('Has footer', {
21-
true: 'Popover footer',
21+
true: figma.string('Popover footer'),
2222
false: undefined
2323
}),
2424
headerIcon: figma.boolean('Show header icon', {

‎packages/code-connect/components/SimpleList/SimpleList.figma.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { SimpleList } from '@patternfly/react-core';
55

66
figma.connect(
77
SimpleList,
8-
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=4410-20691',
8+
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=4410-20691',
99
{
1010
props: {
1111
children: figma.children('*')

‎packages/code-connect/components/SimpleList/SimpleListGroup.figma.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { SimpleListGroup } from '@patternfly/react-core';
55

66
figma.connect(
77
SimpleListGroup,
8-
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=4410-20708',
8+
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=4410-20708',
99
{
1010
props: {
1111
simpleListItems: figma.children('Simple list item')

‎packages/code-connect/components/SimpleList/SimpleListItem.figma.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { SimpleListItem } from '@patternfly/react-core';
66

77
figma.connect(
88
SimpleListItem,
9-
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=4410-20664',
9+
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=4410-20664',
1010
{
1111
props: {
1212
text: figma.string('Text'),

‎packages/code-connect/components/Skeleton/Skeleton.figma.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { Skeleton } from '@patternfly/react-core';
55

66
figma.connect(
77
Skeleton,
8-
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=790-288',
8+
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=790-288&',
99
{
1010
props: {
1111
// enum

‎packages/code-connect/figma.config.json‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,16 @@
88
"components/SimpleList/*.tsx",
99
"components/Skeleton/*.tsx"
1010
],
11-
"paths": {
12-
"src/components": "src/components"
13-
},
1411
"documentUrlSubstitutions": {
15-
"https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components": "https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/branch/Em2QWrHDxDS4LUxo58Hust/PatternFly-6--Components"
12+
"https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components": "https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/branch/e1OeQDrgPKW13FswRqSP3I/PatternFly-6--Components"
13+
},
14+
"paths": {
15+
"@patternfly/react-core": "/Users/mnolting/Web/patternfly-react/packages/react-core/src",
16+
"@patternfly/react-table": "/Users/mnolting/Web/patternfly-react/packages/react-table/src"
1617
},
1718
"aliases": {
18-
"@patternfly/react-core": "."
19+
"@patternfly/react-core": "/Users/mnolting/Web/patternfly-react/packages/react-core/src",
20+
"@patternfly/react-table": "/Users/mnolting/Web/patternfly-react/packages/react-table/src"
1921
},
2022
"importPaths": {
2123
"src/components": "src/components"
@@ -31,6 +33,7 @@
3133
"production": {
3234
"enabled": false
3335
}
34-
}
36+
},
37+
"exclude": ["node_modules/**", "scripts/**"]
3538
}
36-
}
39+
}

0 commit comments

Comments
 (0)