Skip to content

Commit 5573ba5

Browse files
committed
fix: removed inline styles by using Grid component and added hasAnimations prop to Table
1 parent 96bf1f6 commit 5573ba5

1 file changed

Lines changed: 50 additions & 48 deletions

File tree

packages/react-core/src/demos/Animations/examples/Animations.tsx

Lines changed: 50 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ import {
4444
FormHelperText,
4545
FormAlert,
4646
FormGroupLabelHelp,
47-
Gallery,
48-
GalleryItem,
4947
HelperText,
5048
HelperTextItem,
5149
Icon,
@@ -1149,54 +1147,58 @@ export const Animations: FunctionComponent = () => {
11491147
);
11501148
};
11511149

1150+
const DetailsCard: FunctionComponent = () => (
1151+
<Card>
1152+
<CardTitle>
1153+
<Title headingLevel="h4" size="xl">
1154+
Details
1155+
</Title>
1156+
</CardTitle>
1157+
<CardBody>
1158+
<DescriptionList>
1159+
<DescriptionListGroup>
1160+
<DescriptionListTerm>Cluster API Address</DescriptionListTerm>
1161+
<DescriptionListDescription>
1162+
<a href="#">https://api1.devcluster.openshift.com</a>
1163+
</DescriptionListDescription>
1164+
</DescriptionListGroup>
1165+
<DescriptionListGroup>
1166+
<DescriptionListTerm>Cluster ID</DescriptionListTerm>
1167+
<DescriptionListDescription>63b97ac1-b850-41d9-8820-239becde9e86</DescriptionListDescription>
1168+
</DescriptionListGroup>
1169+
<DescriptionListGroup>
1170+
<DescriptionListTerm>Provide</DescriptionListTerm>
1171+
<DescriptionListDescription>AWS</DescriptionListDescription>
1172+
</DescriptionListGroup>
1173+
<DescriptionListGroup>
1174+
<DescriptionListTerm>OpenShift Version</DescriptionListTerm>
1175+
<DescriptionListDescription>4.5.0.ci-2020-06-16-015028</DescriptionListDescription>
1176+
</DescriptionListGroup>
1177+
<DescriptionListGroup>
1178+
<DescriptionListTerm>Update Channel</DescriptionListTerm>
1179+
<DescriptionListDescription>stable-4.5</DescriptionListDescription>
1180+
</DescriptionListGroup>
1181+
</DescriptionList>
1182+
</CardBody>
1183+
<Divider />
1184+
<CardFooter>
1185+
<a href="#">View Settings</a>
1186+
</CardFooter>
1187+
</Card>
1188+
);
1189+
11521190
const detailStatusEvents = (
1153-
<Gallery hasGutter style={{ width: '100%', display: 'grid', gridTemplateColumns: 'repeat(3, 1fr)' }}>
1154-
<GalleryItem>
1155-
<Card>
1156-
<CardTitle>
1157-
<Title headingLevel="h4" size="xl">
1158-
Details
1159-
</Title>
1160-
</CardTitle>
1161-
<CardBody>
1162-
<DescriptionList>
1163-
<DescriptionListGroup>
1164-
<DescriptionListTerm>Cluster API Address</DescriptionListTerm>
1165-
<DescriptionListDescription>
1166-
<a href="#">https://api1.devcluster.openshift.com</a>
1167-
</DescriptionListDescription>
1168-
</DescriptionListGroup>
1169-
<DescriptionListGroup>
1170-
<DescriptionListTerm>Cluster ID</DescriptionListTerm>
1171-
<DescriptionListDescription>63b97ac1-b850-41d9-8820-239becde9e86</DescriptionListDescription>
1172-
</DescriptionListGroup>
1173-
<DescriptionListGroup>
1174-
<DescriptionListTerm>Provide</DescriptionListTerm>
1175-
<DescriptionListDescription>AWS</DescriptionListDescription>
1176-
</DescriptionListGroup>
1177-
<DescriptionListGroup>
1178-
<DescriptionListTerm>OpenShift Version</DescriptionListTerm>
1179-
<DescriptionListDescription>4.5.0.ci-2020-06-16-015028</DescriptionListDescription>
1180-
</DescriptionListGroup>
1181-
<DescriptionListGroup>
1182-
<DescriptionListTerm>Update Channel</DescriptionListTerm>
1183-
<DescriptionListDescription>stable-4.5</DescriptionListDescription>
1184-
</DescriptionListGroup>
1185-
</DescriptionList>
1186-
</CardBody>
1187-
<Divider />
1188-
<CardFooter>
1189-
<a href="#">View Settings</a>
1190-
</CardFooter>
1191-
</Card>
1192-
</GalleryItem>
1193-
<GalleryItem>
1191+
<Grid hasGutter>
1192+
<GridItem span={4}>
1193+
<DetailsCard />
1194+
</GridItem>
1195+
<GridItem span={4}>
11941196
<CardStatus />
1195-
</GalleryItem>
1196-
<GalleryItem>
1197+
</GridItem>
1198+
<GridItem span={4}>
11971199
<EventsCard />
1198-
</GalleryItem>
1199-
</Gallery>
1200+
</GridItem>
1201+
</Grid>
12001202
);
12011203

12021204
const expandableColumns = ['Applications', 'Server', 'Branch', 'Status'];
@@ -1244,7 +1246,7 @@ export const Animations: FunctionComponent = () => {
12441246
{loading ? (
12451247
<SkeletonTable columns={['', ...expandableColumns]} rows={8} />
12461248
) : (
1247-
<Table aria-label="Collapsible table">
1249+
<Table aria-label="Collapsible table" isExpandable hasAnimations>
12481250
<Thead>
12491251
<Tr>
12501252
<Th

0 commit comments

Comments
 (0)