Skip to content

Commit 6de29bc

Browse files
committed
fix(RhMicronCaretDown): Replace with fill for menus
Design reports that filled icon is needed here.
1 parent 8edf04a commit 6de29bc

9 files changed

Lines changed: 12 additions & 14 deletions

File tree

packages/react-core/src/components/Breadcrumb/examples/Breadcrumb.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ ouia: true
88

99
import { useRef, useState } from 'react';
1010
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
11-
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
11+
import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon';
1212

1313
## Examples
1414

packages/react-core/src/components/FormSelect/FormSelect.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { ValidatedOptions } from '../../helpers/constants';
66
import { FormControlIcon } from '../FormControl/FormControlIcon';
77
import { getOUIAProps, OUIAProps } from '../../helpers';
88
import { SSRSafeIds } from '../../helpers/SSRSafeIds/SSRSafeIds';
9-
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
9+
import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon';
1010

1111
export interface FormSelectProps
1212
extends Omit<React.HTMLProps<HTMLSelectElement>, 'onChange' | 'onBlur' | 'onFocus' | 'disabled'>, OUIAProps {
@@ -98,7 +98,7 @@ class FormSelect extends Component<FormSelectProps> {
9898
<span className={css(styles.formControlUtilities)}>
9999
{hasStatusIcon && <FormControlIcon status={validated as 'success' | 'error' | 'warning'} />}
100100
<span className={css(styles.formControlToggleIcon)}>
101-
<RhMicronsCaretDownIcon />
101+
<RhMicronsCaretDownFillIcon />
102102
</span>
103103
</span>
104104
</span>

packages/react-core/src/components/Menu/examples/Menu.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import RhUiTableIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-table-ic
3030
import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon';
3131
import RhUiStorageDomainFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-storage-domain-fill-icon';
3232
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
33-
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
33+
import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon';
3434

3535
## Examples
3636

packages/react-core/src/components/MenuToggle/MenuToggle.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Component, forwardRef, isValidElement } from 'react';
22
import styles from '@patternfly/react-styles/css/components/MenuToggle/menu-toggle';
33
import { css } from '@patternfly/react-styles';
4-
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
4+
import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon';
55
import { BadgeProps } from '../Badge';
66
import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon';
77
import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-check-circle-fill-icon';
@@ -154,7 +154,7 @@ class MenuToggleBase extends Component<MenuToggleProps> {
154154
<span className={css(styles.menuToggleControls)}>
155155
{status !== undefined && <span className={css(styles.menuToggleStatusIcon)}>{_statusIcon}</span>}
156156
<span className={css(styles.menuToggleToggleIcon)}>
157-
<RhMicronsCaretDownIcon />
157+
<RhMicronsCaretDownFillIcon />
158158
</span>
159159
</span>
160160
);

packages/react-core/src/components/Modal/examples/Modal.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ ouia: true
88

99
import { Fragment, useRef, useState } from 'react';
1010
import WarningTriangleIcon from '@patternfly/react-icons/dist/esm/icons/warning-triangle-icon';
11-
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
1211
import RhUiAttentionBellFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-attention-bell-fill-icon';
1312
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
1413
import formStyles from '@patternfly/react-styles/css/components/Form/form';

packages/react-core/src/components/SearchInput/SearchInput.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import AngleUpIcon from '@patternfly/react-icons/dist/esm/icons/angle-up-icon';
88
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
99
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
1010
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
11-
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
11+
import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon';
1212
import { AdvancedSearchMenu } from './AdvancedSearchMenu';
1313
import { TextInputGroup, TextInputGroupMain, TextInputGroupUtilities } from '../TextInputGroup';
1414
import { InputGroup, InputGroupItem } from '../InputGroup';
@@ -465,7 +465,7 @@ const SearchInputBase: React.FunctionComponent<SearchInputProps> = ({
465465
onClick={onToggle}
466466
isDisabled={isDisabled}
467467
aria-expanded={isSearchMenuOpen}
468-
icon={<RhMicronsCaretDownIcon />}
468+
icon={<RhMicronsCaretDownFillIcon />}
469469
/>
470470
</InputGroupItem>
471471
)}

packages/react-core/src/demos/CustomMenus/CustomMenus.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-
1717
import RhUiThumbnailViewSmallFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-thumbnail-view-small-fill-icon';
1818
import brandImg from '../assets/PF-IconLogo.svg';
1919
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
20-
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
21-
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
20+
import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon';
21+
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
2222
import avatarImg from '../assets/avatarImg.svg';
2323
import { css } from '@patternfly/react-styles';
2424
import styles from '@patternfly/react-styles/css/components/Menu/menu';

packages/react-core/src/deprecated/components/Modal/examples/Modal.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { Fragment, useRef, useState } from 'react';
1111

1212
import { Modal as ModalDeprecated, ModalVariant as ModalVariantDeprecated } from '@patternfly/react-core/deprecated';
1313
import WarningTriangleIcon from '@patternfly/react-icons/dist/esm/icons/warning-triangle-icon';
14-
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
1514
import RhUiAttentionBellFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-attention-bell-fill-icon';
1615
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
1716
import spacing from '@patternfly/react-styles/css/utilities/Spacing/spacing';

packages/react-integration/demo-app-ts/src/components/demos/BreadcrumbDemo/BreadcrumbDemo.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
MenuToggle
1212
} from '@patternfly/react-core';
1313
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
14-
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
14+
import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon';
1515

1616
export class BreadcrumbDemo extends Component {
1717
static displayName = 'BreadcrumbDemo';
@@ -74,7 +74,7 @@ export class BreadcrumbDemo extends Component {
7474
<Badge isRead screenReaderText="additional items">
7575
{dropdownItems.length}
7676
<span>
77-
<RhMicronsCaretDownIcon />
77+
<RhMicronsCaretDownFillIcon />
7878
</span>
7979
</Badge>
8080
</MenuToggle>

0 commit comments

Comments
 (0)