Skip to content

Commit 7c67fac

Browse files
committed
fix(NavItem): safely call onSelect in handleNavItemClick and adjust sidebar toggle condition
1 parent 33f7a99 commit 7c67fac

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/react-core/src/components/Nav/NavItem.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,9 @@ const NavItemBase: React.FunctionComponent<NavItemProps> = ({
196196
const tabIndex = isSidebarOpen ? null : -1;
197197

198198
const handleNavItemClick = (event: any, context: NavContextProps, preventLinkDefault: boolean) => {
199-
context.onSelect(event, groupId, itemId, to, preventLinkDefault, onClick);
199+
context.onSelect?.(event, groupId, itemId, to, preventLinkDefault, onClick);
200200

201-
if (isManagedSidebar && isMobile && isSidebarOpen) {
201+
if (isManagedSidebar && isMobile && isSidebarOpen && !hasFlyout) {
202202
onSidebarToggle();
203203
}
204204
};

0 commit comments

Comments
 (0)