Skip to content

Commit 8a28744

Browse files
committed
bump core for class name, remove warning
1 parent 213a741 commit 8a28744

File tree

8 files changed

+22
-29
lines changed

8 files changed

+22
-29
lines changed

packages/react-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"tslib": "^2.8.1"
5555
},
5656
"devDependencies": {
57-
"@patternfly/patternfly": "6.5.0-prerelease.55",
57+
"@patternfly/patternfly": "6.5.0-prerelease.58",
5858
"case-anything": "^3.1.2",
5959
"css": "^3.0.0",
6060
"fs-extra": "^11.3.3"

packages/react-docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"test:a11y": "patternfly-a11y --config patternfly-a11y.config"
2424
},
2525
"dependencies": {
26-
"@patternfly/patternfly": "6.5.0-prerelease.55",
26+
"@patternfly/patternfly": "6.5.0-prerelease.58",
2727
"@patternfly/react-charts": "workspace:^",
2828
"@patternfly/react-code-editor": "workspace:^",
2929
"@patternfly/react-core": "workspace:^",

packages/react-icons/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"@fortawesome/free-brands-svg-icons": "^5.15.4",
3636
"@fortawesome/free-regular-svg-icons": "^5.15.4",
3737
"@fortawesome/free-solid-svg-icons": "^5.15.4",
38-
"@patternfly/patternfly": "6.5.0-prerelease.55",
38+
"@patternfly/patternfly": "6.5.0-prerelease.58",
3939
"@rhds/icons": "^2.1.0",
4040
"fs-extra": "^11.3.3",
4141
"tslib": "^2.8.1"

packages/react-styles/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"clean": "rimraf dist css"
2020
},
2121
"devDependencies": {
22-
"@patternfly/patternfly": "6.5.0-prerelease.55",
22+
"@patternfly/patternfly": "6.5.0-prerelease.58",
2323
"change-case": "^5.4.4",
2424
"fs-extra": "^11.3.3"
2525
},

packages/react-table/src/components/Table/Table.tsx

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export interface TableProps extends React.HTMLProps<HTMLTableElement>, OUIAProps
5050
role?: string;
5151
/** @beta Flag indicating if the table should have plain styling with a transparent background */
5252
isPlain?: boolean;
53-
/** @beta Flag indicating if the table should not have plain styling when in the glass theme. If isPlain is also set, this property will be ignored. */
53+
/** @beta Flag indicating if the table should not have plain styling when in the glass theme */
5454
isNoPlainOnGlass?: boolean;
5555
/** If set to true, the table header sticks to the top of its container */
5656
isStickyHeader?: boolean;
@@ -124,13 +124,6 @@ const TableBase: React.FunctionComponent<TableProps> = ({
124124
const [hasSelectableRows, setHasSelectableRows] = useState(false);
125125
const [tableCaption, setTableCaption] = useState<React.JSX.Element | undefined>();
126126

127-
if (isPlain && isNoPlainOnGlass) {
128-
// eslint-disable-next-line no-console
129-
console.warn(
130-
"Table: When both isPlain and isNoPlainOnGlass are true, isPlain will take precedence and isNoPlainOnGlass will have no effect. It's recommended to pass only one prop according to the current theme."
131-
);
132-
}
133-
134127
useEffect(() => {
135128
document.addEventListener('keydown', handleKeys);
136129

@@ -236,7 +229,7 @@ const TableBase: React.FunctionComponent<TableProps> = ({
236229
isStriped && styles.modifiers.striped,
237230
isExpandable && styles.modifiers.expandable,
238231
isPlain && styles.modifiers.plain,
239-
isNoPlainOnGlass && styles.modifiers.noPlain,
232+
isNoPlainOnGlass && styles.modifiers.noPlainOnGlass,
240233
hasNoInset && stylesTreeView.modifiers.noInset,
241234
isNested && 'pf-m-nested',
242235
hasAnimations && styles.modifiers.animateExpand

packages/react-table/src/components/Table/__tests__/Table.test.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -169,20 +169,20 @@ test(`Does not render with class ${styles.modifiers.plain} when isPlain is false
169169
expect(screen.getByRole('grid', { name: 'Test table' })).not.toHaveClass(styles.modifiers.plain);
170170
});
171171

172-
test(`Renders with class ${styles.modifiers.noPlain} when isNoPlainOnGlass is true`, () => {
172+
test(`Renders with class ${styles.modifiers.noPlainOnGlass} when isNoPlainOnGlass is true`, () => {
173173
render(<Table isNoPlainOnGlass aria-label="Test table" />);
174174

175-
expect(screen.getByRole('grid', { name: 'Test table' })).toHaveClass(styles.modifiers.noPlain);
175+
expect(screen.getByRole('grid', { name: 'Test table' })).toHaveClass(styles.modifiers.noPlainOnGlass);
176176
});
177177

178-
test(`Does not render with class ${styles.modifiers.noPlain} when isNoPlainOnGlass is undefined`, () => {
178+
test(`Does not render with class ${styles.modifiers.noPlainOnGlass} when isNoPlainOnGlass is undefined`, () => {
179179
render(<Table aria-label="Test table" />);
180180

181-
expect(screen.getByRole('grid', { name: 'Test table' })).not.toHaveClass(styles.modifiers.noPlain);
181+
expect(screen.getByRole('grid', { name: 'Test table' })).not.toHaveClass(styles.modifiers.noPlainOnGlass);
182182
});
183183

184-
test(`Does not render with class ${styles.modifiers.noPlain} when isNoPlainOnGlass is false`, () => {
184+
test(`Does not render with class ${styles.modifiers.noPlainOnGlass} when isNoPlainOnGlass is false`, () => {
185185
render(<Table isNoPlainOnGlass={false} aria-label="Test table" />);
186186

187-
expect(screen.getByRole('grid', { name: 'Test table' })).not.toHaveClass(styles.modifiers.noPlain);
187+
expect(screen.getByRole('grid', { name: 'Test table' })).not.toHaveClass(styles.modifiers.noPlainOnGlass);
188188
});

packages/react-tokens/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
},
3131
"devDependencies": {
3232
"@adobe/css-tools": "^4.4.4",
33-
"@patternfly/patternfly": "6.5.0-prerelease.55",
33+
"@patternfly/patternfly": "6.5.0-prerelease.58",
3434
"fs-extra": "^11.3.3"
3535
}
3636
}

yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5079,10 +5079,10 @@ __metadata:
50795079
languageName: node
50805080
linkType: hard
50815081

5082-
"@patternfly/patternfly@npm:6.5.0-prerelease.55":
5083-
version: 6.5.0-prerelease.55
5084-
resolution: "@patternfly/patternfly@npm:6.5.0-prerelease.55"
5085-
checksum: 10c0/02921ae29db7ac07ec977589b5233397536831d818372289f040685835031562bff398f9e5cd594210bfc6d216dbbf22a9d70a454a5d044bb99e53e186651f1e
5082+
"@patternfly/patternfly@npm:6.5.0-prerelease.58":
5083+
version: 6.5.0-prerelease.58
5084+
resolution: "@patternfly/patternfly@npm:6.5.0-prerelease.58"
5085+
checksum: 10c0/b2262ff41ee3cbf376e978e2e9c2290f105c1784b2f7968981769221f464afb9aac84b91462581f58b55bc9fb6a71d617253bbbf69f30ea89f5117122c78c154
50865086
languageName: node
50875087
linkType: hard
50885088

@@ -5180,7 +5180,7 @@ __metadata:
51805180
version: 0.0.0-use.local
51815181
resolution: "@patternfly/react-core@workspace:packages/react-core"
51825182
dependencies:
5183-
"@patternfly/patternfly": "npm:6.5.0-prerelease.55"
5183+
"@patternfly/patternfly": "npm:6.5.0-prerelease.58"
51845184
"@patternfly/react-icons": "workspace:^"
51855185
"@patternfly/react-styles": "workspace:^"
51865186
"@patternfly/react-tokens": "workspace:^"
@@ -5201,7 +5201,7 @@ __metadata:
52015201
resolution: "@patternfly/react-docs@workspace:packages/react-docs"
52025202
dependencies:
52035203
"@patternfly/documentation-framework": "npm:^6.36.7"
5204-
"@patternfly/patternfly": "npm:6.5.0-prerelease.55"
5204+
"@patternfly/patternfly": "npm:6.5.0-prerelease.58"
52055205
"@patternfly/patternfly-a11y": "npm:5.1.0"
52065206
"@patternfly/react-charts": "workspace:^"
52075207
"@patternfly/react-code-editor": "workspace:^"
@@ -5241,7 +5241,7 @@ __metadata:
52415241
"@fortawesome/free-brands-svg-icons": "npm:^5.15.4"
52425242
"@fortawesome/free-regular-svg-icons": "npm:^5.15.4"
52435243
"@fortawesome/free-solid-svg-icons": "npm:^5.15.4"
5244-
"@patternfly/patternfly": "npm:6.5.0-prerelease.55"
5244+
"@patternfly/patternfly": "npm:6.5.0-prerelease.58"
52455245
"@rhds/icons": "npm:^2.1.0"
52465246
fs-extra: "npm:^11.3.3"
52475247
tslib: "npm:^2.8.1"
@@ -5328,7 +5328,7 @@ __metadata:
53285328
version: 0.0.0-use.local
53295329
resolution: "@patternfly/react-styles@workspace:packages/react-styles"
53305330
dependencies:
5331-
"@patternfly/patternfly": "npm:6.5.0-prerelease.55"
5331+
"@patternfly/patternfly": "npm:6.5.0-prerelease.58"
53325332
change-case: "npm:^5.4.4"
53335333
fs-extra: "npm:^11.3.3"
53345334
languageName: unknown
@@ -5370,7 +5370,7 @@ __metadata:
53705370
resolution: "@patternfly/react-tokens@workspace:packages/react-tokens"
53715371
dependencies:
53725372
"@adobe/css-tools": "npm:^4.4.4"
5373-
"@patternfly/patternfly": "npm:6.5.0-prerelease.55"
5373+
"@patternfly/patternfly": "npm:6.5.0-prerelease.58"
53745374
fs-extra: "npm:^11.3.3"
53755375
languageName: unknown
53765376
linkType: soft

0 commit comments

Comments
 (0)