Skip to content

Commit 909f747

Browse files
fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhUiSortDownSmallToLargeIcon (#12485)
* fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhUiSortDownSmallToLargeIcon Co-authored-by: Cursor <cursoragent@cursor.com> * fix(PficonSortCommonAscIcon): Use RhMicronsSortDownSmallToLargeIcon instead of RhUiSortDownSmallToLargeIcon Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 29f223e commit 909f747

9 files changed

Lines changed: 15 additions & 17 deletions

File tree

packages/react-core/src/components/DualListSelector/examples/DualListSelector.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
2020
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
2121
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
2222
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
23-
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
23+
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
2424
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
2525
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
2626
import { DragDropSort, DragDropContainer, Droppable as NewDroppable } from '@patternfly/react-drag-drop';

packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
2525
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
2626
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
2727
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
28-
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
28+
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
2929
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
3030
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
3131

@@ -155,7 +155,7 @@ export const DualListSelectorComplexOptionsActionsNext: React.FunctionComponent
155155
aria-label="Sort Available"
156156
key="availableSortButton"
157157
isDisabled={isDisabled}
158-
icon={<PficonSortCommonAscIcon />}
158+
icon={<RhMicronsSortDownSmallToLargeIcon />}
159159
/>,
160160
<Dropdown
161161
toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
@@ -190,7 +190,7 @@ export const DualListSelectorComplexOptionsActionsNext: React.FunctionComponent
190190
aria-label="Sort Chosen"
191191
key="chosenSortButton"
192192
isDisabled={isDisabled}
193-
icon={<PficonSortCommonAscIcon />}
193+
icon={<RhMicronsSortDownSmallToLargeIcon />}
194194
/>,
195195
<Dropdown
196196
toggle={(toggleRef: React.Ref<MenuToggleElement>) => (

packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
3333
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
3434
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
3535
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
36-
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
36+
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
3737
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
3838

3939
## Examples

packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Fragment, useState } from 'react';
22
import { Button, ButtonVariant, Checkbox } from '@patternfly/react-core';
33
import { DualListSelector as DLSDeprecated } from '@patternfly/react-core/deprecated';
4-
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
4+
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
55

66
export const DualListSelectorComplexOptionsActions: React.FunctionComponent = () => {
77
const [availableOptions, setAvailableOptions] = useState<React.ReactNode[]>([
@@ -47,7 +47,7 @@ export const DualListSelectorComplexOptionsActions: React.FunctionComponent = ()
4747
aria-label="Sort available options"
4848
key="availableSortButton"
4949
isDisabled={isDisabled}
50-
icon={<PficonSortCommonAscIcon />}
50+
icon={<RhMicronsSortDownSmallToLargeIcon />}
5151
/>
5252
];
5353

@@ -58,7 +58,7 @@ export const DualListSelectorComplexOptionsActions: React.FunctionComponent = ()
5858
aria-label="Sort chosen options"
5959
key="chosenSortButton"
6060
isDisabled={isDisabled}
61-
icon={<PficonSortCommonAscIcon />}
61+
icon={<RhMicronsSortDownSmallToLargeIcon />}
6262
/>
6363
];
6464

packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
2121
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
2222
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
2323
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
24-
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
24+
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
2525
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
2626

2727
interface Option {
@@ -137,7 +137,7 @@ export const DualListSelectorComposable: React.FunctionComponent = () => {
137137
onClick={onSort}
138138
aria-label="Sort"
139139
key="sortButton"
140-
icon={<PficonSortCommonAscIcon />}
140+
icon={<RhMicronsSortDownSmallToLargeIcon />}
141141
/>
142142
);
143143
};

packages/react-drag-drop/src/components/DragDrop/examples/DragDrop.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
1313
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
1414
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
1515
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
16-
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
1716

1817
import { DragDropSort, DragDropContainer, Droppable as NewDroppable } from '@patternfly/react-drag-drop';
1918

packages/react-drag-drop/src/components/DragDrop/examples/DragDropDemos.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
1212
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
1313
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
1414
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
15-
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
1615

1716
import { DragDropSort, DragDropContainer, Droppable as NewDroppable } from '@patternfly/react-drag-drop';
1817

packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorWithActionsDemo.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
2525
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
2626
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
2727
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
28-
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
2928
import RhUiSortDownLargeToSmallIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-sort-down-large-to-small-icon';
29+
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
3030
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
3131
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
3232

@@ -133,7 +133,7 @@ export const DualListSelectorWithActionsDemo: React.FunctionComponent = () => {
133133
return direction === 'asc' ? 'ascending' : 'descending';
134134
},
135135
getIcon(direction: SortDirection) {
136-
return direction === 'asc' ? <PficonSortCommonAscIcon /> : <RhUiSortDownLargeToSmallIcon />;
136+
return direction === 'asc' ? <RhMicronsSortDownSmallToLargeIcon /> : <RhUiSortDownLargeToSmallIcon />;
137137
}
138138
};
139139

packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDeprecatedDemo/DualListSelectorDeprecatedWithActionsDemo.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import {
55
DualListSelectorProps as DLSPropsDeprecated
66
} from '@patternfly/react-core/deprecated';
77
import RhUiSortDownLargeToSmallIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-sort-down-large-to-small-icon';
8-
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
98
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
9+
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
1010

1111
interface DualListSelectorState {
1212
availableOptions: React.ReactNode[];
@@ -126,7 +126,7 @@ class DualListSelectorDeprecatedWithActionsDemo extends Component<DLSPropsDeprec
126126
onClick={() => this.onSort('available')}
127127
aria-label="Sort"
128128
key="availableSortButton"
129-
icon={this.state.availableDescending ? <RhUiSortDownLargeToSmallIcon /> : <PficonSortCommonAscIcon />}
129+
icon={this.state.availableDescending ? <RhUiSortDownLargeToSmallIcon /> : <RhMicronsSortDownSmallToLargeIcon />}
130130
/>,
131131
<Dropdown
132132
key="availableDropdown"
@@ -153,7 +153,7 @@ class DualListSelectorDeprecatedWithActionsDemo extends Component<DLSPropsDeprec
153153
onClick={() => this.onSort('chosen')}
154154
aria-label="Sort"
155155
key="chosenSortButton"
156-
icon={this.state.chosenDescending ? <RhUiSortDownLargeToSmallIcon /> : <PficonSortCommonAscIcon />}
156+
icon={this.state.chosenDescending ? <RhUiSortDownLargeToSmallIcon /> : <RhMicronsSortDownSmallToLargeIcon />}
157157
/>,
158158
<Dropdown
159159
isOpen={this.state.isChosenKebabOpen}

0 commit comments

Comments
 (0)