Skip to content

Commit 9b83a06

Browse files
rebeccaalpertrebeccaalpert
committed
Address feedback and Figma updates
1 parent 579301b commit 9b83a06

2 files changed

Lines changed: 11 additions & 10 deletions

File tree

‎packages/react-core/src/components/SearchInput/SearchInput.tsx‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import { Icon } from '../Icon';
66
import RhMicronsCaretUpIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-up-icon';
77
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
88
import RhMicronsSearchIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-search-icon';
9-
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
9+
import RhMicronsArrowRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-arrow-right-icon';
10+
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
1011
import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon';
1112
import { AdvancedSearchMenu } from './AdvancedSearchMenu';
1213
import { TextInputGroup, TextInputGroupMain, TextInputGroupUtilities } from '../TextInputGroup';
@@ -339,7 +340,7 @@ const SearchInputBase: React.FunctionComponent<SearchInputProps> = ({
339340
aria-label={nextNavigationButtonAriaLabel}
340341
isDisabled={isDisabled || isNextNavigationButtonDisabled}
341342
onClick={onNextClick}
342-
icon={<RhMicronsCaretDownFillIcon />}
343+
icon={<RhMicronsCaretDownIcon />}
343344
/>
344345
</div>
345346
)}
@@ -478,7 +479,7 @@ const SearchInputBase: React.FunctionComponent<SearchInputProps> = ({
478479
isDisabled={isDisabled}
479480
icon={
480481
<Icon shouldMirrorRTL>
481-
<RhMicronsCaretRightIcon />
482+
<RhMicronsArrowRightIcon />
482483
</Icon>
483484
}
484485
/>

‎packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ exports[`SearchInput advanced search 1`] = `
129129
width="1em"
130130
>
131131
<path
132-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
132+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
133133
/>
134134
</svg>
135135
</span>
@@ -272,7 +272,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
272272
width="1em"
273273
>
274274
<path
275-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
275+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
276276
/>
277277
</svg>
278278
</span>
@@ -605,7 +605,7 @@ exports[`SearchInput renders search input in strict mode 1`] = `
605605
width="1em"
606606
>
607607
<path
608-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
608+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
609609
/>
610610
</svg>
611611
</span>
@@ -714,7 +714,7 @@ exports[`SearchInput search input with hint 1`] = `
714714
width="1em"
715715
>
716716
<path
717-
d="m17.65 8.76-6.674 5.72a1.496 1.496 0 0 1-.976.365c-.347 0-.694-.122-.978-.366l-6.673-5.72A1 1 0 0 1 3 7h14a1 1 0 0 1 .65 1.76Z"
717+
d="M18.71 5.29a.996.996 0 0 0-1.41 0l-7.29 7.29-7.3-7.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 7.65 7.65c.29.29.68.44 1.06.44s.77-.15 1.06-.44l7.65-7.65a.996.996 0 0 0 0-1.41Z"
718718
/>
719719
</svg>
720720
</span>
@@ -773,7 +773,7 @@ exports[`SearchInput search input with hint 1`] = `
773773
width="1em"
774774
>
775775
<path
776-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
776+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
777777
/>
778778
</svg>
779779
</span>
@@ -874,7 +874,7 @@ exports[`SearchInput simple search input 1`] = `
874874
width="1em"
875875
>
876876
<path
877-
d="m17.65 8.76-6.674 5.72a1.496 1.496 0 0 1-.976.365c-.347 0-.694-.122-.978-.366l-6.673-5.72A1 1 0 0 1 3 7h14a1 1 0 0 1 .65 1.76Z"
877+
d="M18.71 5.29a.996.996 0 0 0-1.41 0l-7.29 7.29-7.3-7.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 7.65 7.65c.29.29.68.44 1.06.44s.77-.15 1.06-.44l7.65-7.65a.996.996 0 0 0 0-1.41Z"
878878
/>
879879
</svg>
880880
</span>
@@ -933,7 +933,7 @@ exports[`SearchInput simple search input 1`] = `
933933
width="1em"
934934
>
935935
<path
936-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
936+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
937937
/>
938938
</svg>
939939
</span>

0 commit comments

Comments
 (0)