Skip to content

Commit a7d4365

Browse files
rebeccaalpertcursoragent
rebeccaalpert
and
cursoragent
authored
fix(AngleUpIcon): Replace AngleUpIcon with RhMicronsCaretUpIcon (#12497)
* fix(AngleUpIcon): Replace AngleUpIcon with RhMicronsCaretUpIcon Co-authored-by: Cursor <cursoragent@cursor.com> * Address feedback and Figma updates --------- Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 389b3d2 commit a7d4365

2 files changed

Lines changed: 21 additions & 44 deletions

File tree

‎packages/react-core/src/components/SearchInput/SearchInput.tsx‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ import { css } from '@patternfly/react-styles';
33
import { Button, ButtonVariant } from '../Button';
44
import { Badge } from '../Badge';
55
import { Icon } from '../Icon';
6-
import AngleUpIcon from '@patternfly/react-icons/dist/esm/icons/angle-up-icon';
6+
import RhMicronsCaretUpIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-up-icon';
77
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
88
import RhMicronsSearchIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-search-icon';
9-
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
9+
import RhMicronsArrowRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-arrow-right-icon';
10+
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
1011
import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon';
1112
import { AdvancedSearchMenu } from './AdvancedSearchMenu';
1213
import { TextInputGroup, TextInputGroupMain, TextInputGroupUtilities } from '../TextInputGroup';
@@ -332,14 +333,14 @@ const SearchInputBase: React.FunctionComponent<SearchInputProps> = ({
332333
aria-label={previousNavigationButtonAriaLabel}
333334
isDisabled={isDisabled || isPreviousNavigationButtonDisabled}
334335
onClick={onPreviousClick}
335-
icon={<AngleUpIcon />}
336+
icon={<RhMicronsCaretUpIcon />}
336337
/>
337338
<Button
338339
variant={ButtonVariant.plain}
339340
aria-label={nextNavigationButtonAriaLabel}
340341
isDisabled={isDisabled || isNextNavigationButtonDisabled}
341342
onClick={onNextClick}
342-
icon={<RhMicronsCaretDownFillIcon />}
343+
icon={<RhMicronsCaretDownIcon />}
343344
/>
344345
</div>
345346
)}
@@ -478,7 +479,7 @@ const SearchInputBase: React.FunctionComponent<SearchInputProps> = ({
478479
isDisabled={isDisabled}
479480
icon={
480481
<Icon shouldMirrorRTL>
481-
<RhMicronsCaretRightIcon />
482+
<RhMicronsArrowRightIcon />
482483
</Icon>
483484
}
484485
/>

‎packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap‎

Lines changed: 15 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ exports[`SearchInput advanced search 1`] = `
129129
width="1em"
130130
>
131131
<path
132-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
132+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
133133
/>
134134
</svg>
135135
</span>
@@ -272,7 +272,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
272272
width="1em"
273273
>
274274
<path
275-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
275+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
276276
/>
277277
</svg>
278278
</span>
@@ -605,7 +605,7 @@ exports[`SearchInput renders search input in strict mode 1`] = `
605605
width="1em"
606606
>
607607
<path
608-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
608+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
609609
/>
610610
</svg>
611611
</span>
@@ -687,24 +687,12 @@ exports[`SearchInput search input with hint 1`] = `
687687
fill="currentColor"
688688
height="1em"
689689
role="img"
690+
viewBox="0 0 20 20"
690691
width="1em"
691692
>
692-
<svg
693-
class="pf-v6-icon-default"
694-
viewBox="0 0 320 512"
695-
>
696-
<path
697-
d="M177 159.7l136 136c9.4 9.4 9.4 24.6 0 33.9l-22.6 22.6c-9.4 9.4-24.6 9.4-33.9 0L160 255.9l-96.4 96.4c-9.4 9.4-24.6 9.4-33.9 0L7 329.7c-9.4-9.4-9.4-24.6 0-33.9l136-136c9.4-9.5 24.6-9.5 34-.1z"
698-
/>
699-
</svg>
700-
<svg
701-
class="pf-v6-icon-rh-ui"
702-
viewBox="0 0 32 32"
703-
>
704-
<path
705-
d="M29 22a.997.997 0 0 1-.707-.293L16 9.414 3.707 21.707a.999.999 0 1 1-1.414-1.414L14.939 7.646a1.501 1.501 0 0 1 2.121 0l12.646 12.646a.999.999 0 0 1-.707 1.707Z"
706-
/>
707-
</svg>
693+
<path
694+
d="m18.71 13.29-7.65-7.65a1.49 1.49 0 0 0-2.12 0l-7.65 7.65-.02.02c-.38.4-.37 1.03.02 1.41.4.38 1.03.37 1.41-.02l7.29-7.29 7.29 7.29c.19.19.44.29.71.29.27 0 .52-.11.71-.29a.996.996 0 0 0 0-1.41Z"
695+
/>
708696
</svg>
709697
</span>
710698
</button>
@@ -726,7 +714,7 @@ exports[`SearchInput search input with hint 1`] = `
726714
width="1em"
727715
>
728716
<path
729-
d="m17.65 8.76-6.674 5.72a1.496 1.496 0 0 1-.976.365c-.347 0-.694-.122-.978-.366l-6.673-5.72A1 1 0 0 1 3 7h14a1 1 0 0 1 .65 1.76Z"
717+
d="M18.71 5.29a.996.996 0 0 0-1.41 0l-7.29 7.29-7.3-7.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 7.65 7.65c.29.29.68.44 1.06.44s.77-.15 1.06-.44l7.65-7.65a.996.996 0 0 0 0-1.41Z"
730718
/>
731719
</svg>
732720
</span>
@@ -785,7 +773,7 @@ exports[`SearchInput search input with hint 1`] = `
785773
width="1em"
786774
>
787775
<path
788-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
776+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
789777
/>
790778
</svg>
791779
</span>
@@ -859,24 +847,12 @@ exports[`SearchInput simple search input 1`] = `
859847
fill="currentColor"
860848
height="1em"
861849
role="img"
850+
viewBox="0 0 20 20"
862851
width="1em"
863852
>
864-
<svg
865-
class="pf-v6-icon-default"
866-
viewBox="0 0 320 512"
867-
>
868-
<path
869-
d="M177 159.7l136 136c9.4 9.4 9.4 24.6 0 33.9l-22.6 22.6c-9.4 9.4-24.6 9.4-33.9 0L160 255.9l-96.4 96.4c-9.4 9.4-24.6 9.4-33.9 0L7 329.7c-9.4-9.4-9.4-24.6 0-33.9l136-136c9.4-9.5 24.6-9.5 34-.1z"
870-
/>
871-
</svg>
872-
<svg
873-
class="pf-v6-icon-rh-ui"
874-
viewBox="0 0 32 32"
875-
>
876-
<path
877-
d="M29 22a.997.997 0 0 1-.707-.293L16 9.414 3.707 21.707a.999.999 0 1 1-1.414-1.414L14.939 7.646a1.501 1.501 0 0 1 2.121 0l12.646 12.646a.999.999 0 0 1-.707 1.707Z"
878-
/>
879-
</svg>
853+
<path
854+
d="m18.71 13.29-7.65-7.65a1.49 1.49 0 0 0-2.12 0l-7.65 7.65-.02.02c-.38.4-.37 1.03.02 1.41.4.38 1.03.37 1.41-.02l7.29-7.29 7.29 7.29c.19.19.44.29.71.29.27 0 .52-.11.71-.29a.996.996 0 0 0 0-1.41Z"
855+
/>
880856
</svg>
881857
</span>
882858
</button>
@@ -898,7 +874,7 @@ exports[`SearchInput simple search input 1`] = `
898874
width="1em"
899875
>
900876
<path
901-
d="m17.65 8.76-6.674 5.72a1.496 1.496 0 0 1-.976.365c-.347 0-.694-.122-.978-.366l-6.673-5.72A1 1 0 0 1 3 7h14a1 1 0 0 1 .65 1.76Z"
877+
d="M18.71 5.29a.996.996 0 0 0-1.41 0l-7.29 7.29-7.3-7.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 7.65 7.65c.29.29.68.44 1.06.44s.77-.15 1.06-.44l7.65-7.65a.996.996 0 0 0 0-1.41Z"
902878
/>
903879
</svg>
904880
</span>
@@ -957,7 +933,7 @@ exports[`SearchInput simple search input 1`] = `
957933
width="1em"
958934
>
959935
<path
960-
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
936+
d="M18.35 8.94 12.7 3.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 4.29 4.29H2c-.55 0-1 .45-1 1s.45 1 1 1h13.59l-4.29 4.29a.987.987 0 0 0-.02 1.41c.38.4 1.02.41 1.41.02l.02-.02 5.65-5.65c.59-.59.59-1.53 0-2.12Z"
961937
/>
962938
</svg>
963939
</span>

0 commit comments

Comments
 (0)