Skip to content

Commit c1e2dc9

Browse files
dlabajdlabaj
committed
chore: updated with review comments.
1 parent 5503d97 commit c1e2dc9

File tree

2 files changed

+14
-50
lines changed

2 files changed

+14
-50
lines changed

‎packages/react-drag-drop/src/components/DragDrop/DragButton.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { css } from '@patternfly/react-styles';
22
import { Button } from '@patternfly/react-core/dist/esm/components/Button';
33
import dragButtonStyles from '@patternfly/react-styles/css/components/DataList/data-list';
4-
import GripVerticalIcon from '@patternfly/react-icons/dist/esm/icons/grip-vertical-icon';
4+
import RhUiGripVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-grip-vertical-fill-icon';
55

66
export interface DragButtonProps extends Omit<React.HTMLProps<HTMLButtonElement>, 'size'> {
77
/** Additional classes added to the drag button */
@@ -29,7 +29,7 @@ export const DragButton: React.FunctionComponent<DragButtonProps> = ({
2929
aria-labelledby={ariaLabelledby}
3030
icon={
3131
<span className={css(dragButtonStyles.dataListItemDraggableIcon)}>
32-
<GripVerticalIcon />
32+
<RhUiGripVerticalFillIcon />
3333
</span>
3434
}
3535
{...props}

‎packages/react-drag-drop/src/components/DragDrop/__tests__/__snapshots__/DragDrop.test.tsx.snap‎

Lines changed: 12 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -34,24 +34,12 @@ exports[`renders some divs 1`] = `
3434
fill="currentColor"
3535
height="1em"
3636
role="img"
37+
viewBox="0 0 32 32"
3738
width="1em"
3839
>
39-
<svg
40-
class="pf-v6-icon-default"
41-
viewBox="0 0 320 512"
42-
>
43-
<path
44-
d="M96 32H32C14.33 32 0 46.33 0 64v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32V64c0-17.67-14.33-32-32-32zm0 160H32c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32zm0 160H32c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32zM288 32h-64c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32V64c0-17.67-14.33-32-32-32zm0 160h-64c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32zm0 160h-64c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32z"
45-
/>
46-
</svg>
47-
<svg
48-
class="pf-v6-icon-rh-ui"
49-
viewBox="0 0 32 32"
50-
>
51-
<path
52-
d="M12.75 1h-5.5C6.561 1 6 1.561 6 2.25v5.5C6 8.439 6.561 9 7.25 9h5.5C13.439 9 14 8.439 14 7.75v-5.5C14 1.561 13.439 1 12.75 1ZM12 7H8V3h4v4Zm12.75-6h-5.5C18.561 1 18 1.561 18 2.25v5.5c0 .689.561 1.25 1.25 1.25h5.5C25.439 9 26 8.439 26 7.75v-5.5C26 1.561 25.439 1 24.75 1ZM24 7h-4V3h4v4Zm-11.25 5h-5.5C6.561 12 6 12.561 6 13.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM12 18H8v-4h4v4Zm12.75-6h-5.5c-.689 0-1.25.561-1.25 1.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM24 18h-4v-4h4v4Zm-11.25 5h-5.5C6.561 23 6 23.561 6 24.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM12 29H8v-4h4v4Zm12.75-6h-5.5c-.689 0-1.25.561-1.25 1.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM24 29h-4v-4h4v4Z"
53-
/>
54-
</svg>
40+
<path
41+
d="M13.75 2.25v5.5c0 .551-.448 1-1 1h-5.5c-.552 0-1-.449-1-1v-5.5c0-.551.448-1 1-1h5.5c.552 0 1 .449 1 1Zm11-1h-5.5c-.552 0-1 .449-1 1v5.5c0 .551.448 1 1 1h5.5c.552 0 1-.449 1-1v-5.5c0-.551-.448-1-1-1Zm-12 11h-5.5c-.552 0-1 .449-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5c0-.551-.448-1-1-1Zm12 0h-5.5c-.552 0-1 .449-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5c0-.551-.448-1-1-1Zm-12 11h-5.5a1 1 0 0 0-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5a1 1 0 0 0-1-1Zm12 0h-5.5a1 1 0 0 0-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5a1 1 0 0 0-1-1Z"
42+
/>
5543
</svg>
5644
</span>
5745
</span>
@@ -86,24 +74,12 @@ exports[`renders some divs 1`] = `
8674
fill="currentColor"
8775
height="1em"
8876
role="img"
77+
viewBox="0 0 32 32"
8978
width="1em"
9079
>
91-
<svg
92-
class="pf-v6-icon-default"
93-
viewBox="0 0 320 512"
94-
>
95-
<path
96-
d="M96 32H32C14.33 32 0 46.33 0 64v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32V64c0-17.67-14.33-32-32-32zm0 160H32c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32zm0 160H32c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32zM288 32h-64c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32V64c0-17.67-14.33-32-32-32zm0 160h-64c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32zm0 160h-64c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32z"
97-
/>
98-
</svg>
99-
<svg
100-
class="pf-v6-icon-rh-ui"
101-
viewBox="0 0 32 32"
102-
>
103-
<path
104-
d="M12.75 1h-5.5C6.561 1 6 1.561 6 2.25v5.5C6 8.439 6.561 9 7.25 9h5.5C13.439 9 14 8.439 14 7.75v-5.5C14 1.561 13.439 1 12.75 1ZM12 7H8V3h4v4Zm12.75-6h-5.5C18.561 1 18 1.561 18 2.25v5.5c0 .689.561 1.25 1.25 1.25h5.5C25.439 9 26 8.439 26 7.75v-5.5C26 1.561 25.439 1 24.75 1ZM24 7h-4V3h4v4Zm-11.25 5h-5.5C6.561 12 6 12.561 6 13.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM12 18H8v-4h4v4Zm12.75-6h-5.5c-.689 0-1.25.561-1.25 1.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM24 18h-4v-4h4v4Zm-11.25 5h-5.5C6.561 23 6 23.561 6 24.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM12 29H8v-4h4v4Zm12.75-6h-5.5c-.689 0-1.25.561-1.25 1.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM24 29h-4v-4h4v4Z"
105-
/>
106-
</svg>
80+
<path
81+
d="M13.75 2.25v5.5c0 .551-.448 1-1 1h-5.5c-.552 0-1-.449-1-1v-5.5c0-.551.448-1 1-1h5.5c.552 0 1 .449 1 1Zm11-1h-5.5c-.552 0-1 .449-1 1v5.5c0 .551.448 1 1 1h5.5c.552 0 1-.449 1-1v-5.5c0-.551-.448-1-1-1Zm-12 11h-5.5c-.552 0-1 .449-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5c0-.551-.448-1-1-1Zm12 0h-5.5c-.552 0-1 .449-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5c0-.551-.448-1-1-1Zm-12 11h-5.5a1 1 0 0 0-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5a1 1 0 0 0-1-1Zm12 0h-5.5a1 1 0 0 0-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5a1 1 0 0 0-1-1Z"
82+
/>
10783
</svg>
10884
</span>
10985
</span>
@@ -138,24 +114,12 @@ exports[`renders some divs 1`] = `
138114
fill="currentColor"
139115
height="1em"
140116
role="img"
117+
viewBox="0 0 32 32"
141118
width="1em"
142119
>
143-
<svg
144-
class="pf-v6-icon-default"
145-
viewBox="0 0 320 512"
146-
>
147-
<path
148-
d="M96 32H32C14.33 32 0 46.33 0 64v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32V64c0-17.67-14.33-32-32-32zm0 160H32c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32zm0 160H32c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32zM288 32h-64c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32V64c0-17.67-14.33-32-32-32zm0 160h-64c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32zm0 160h-64c-17.67 0-32 14.33-32 32v64c0 17.67 14.33 32 32 32h64c17.67 0 32-14.33 32-32v-64c0-17.67-14.33-32-32-32z"
149-
/>
150-
</svg>
151-
<svg
152-
class="pf-v6-icon-rh-ui"
153-
viewBox="0 0 32 32"
154-
>
155-
<path
156-
d="M12.75 1h-5.5C6.561 1 6 1.561 6 2.25v5.5C6 8.439 6.561 9 7.25 9h5.5C13.439 9 14 8.439 14 7.75v-5.5C14 1.561 13.439 1 12.75 1ZM12 7H8V3h4v4Zm12.75-6h-5.5C18.561 1 18 1.561 18 2.25v5.5c0 .689.561 1.25 1.25 1.25h5.5C25.439 9 26 8.439 26 7.75v-5.5C26 1.561 25.439 1 24.75 1ZM24 7h-4V3h4v4Zm-11.25 5h-5.5C6.561 12 6 12.561 6 13.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM12 18H8v-4h4v4Zm12.75-6h-5.5c-.689 0-1.25.561-1.25 1.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM24 18h-4v-4h4v4Zm-11.25 5h-5.5C6.561 23 6 23.561 6 24.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM12 29H8v-4h4v4Zm12.75-6h-5.5c-.689 0-1.25.561-1.25 1.25v5.5c0 .689.561 1.25 1.25 1.25h5.5c.689 0 1.25-.561 1.25-1.25v-5.5c0-.689-.561-1.25-1.25-1.25ZM24 29h-4v-4h4v4Z"
157-
/>
158-
</svg>
120+
<path
121+
d="M13.75 2.25v5.5c0 .551-.448 1-1 1h-5.5c-.552 0-1-.449-1-1v-5.5c0-.551.448-1 1-1h5.5c.552 0 1 .449 1 1Zm11-1h-5.5c-.552 0-1 .449-1 1v5.5c0 .551.448 1 1 1h5.5c.552 0 1-.449 1-1v-5.5c0-.551-.448-1-1-1Zm-12 11h-5.5c-.552 0-1 .449-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5c0-.551-.448-1-1-1Zm12 0h-5.5c-.552 0-1 .449-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5c0-.551-.448-1-1-1Zm-12 11h-5.5a1 1 0 0 0-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5a1 1 0 0 0-1-1Zm12 0h-5.5a1 1 0 0 0-1 1v5.5a1 1 0 0 0 1 1h5.5a1 1 0 0 0 1-1v-5.5a1 1 0 0 0-1-1Z"
122+
/>
159123
</svg>
160124
</span>
161125
</span>

0 commit comments

Comments
 (0)