Skip to content

Commit d262982

Browse files
wise-king-sullymanwise-king-sullyman
committed
Replace ui caret down icon with microns caret down icon
1 parent 06f62a2 commit d262982

55 files changed

Lines changed: 163 additions & 165 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎packages/react-core/src/components/Accordion/AccordionToggle.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { useContext } from 'react';
22
import { css } from '@patternfly/react-styles';
33
import styles from '@patternfly/react-styles/css/components/Accordion/accordion';
4-
import RhUiCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-caret-down-icon';
4+
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
55
import { AccordionContext, AccordionItemContext } from './AccordionContext';
66

77
export interface AccordionToggleProps extends React.DetailedHTMLProps<
@@ -27,7 +27,7 @@ export const AccordionToggle: React.FunctionComponent<AccordionToggleProps> = ({
2727
}: AccordionToggleProps) => {
2828
const renderToggleIcon = () => (
2929
<span className={css(styles.accordionToggleIcon)}>
30-
<RhUiCaretDownIcon />
30+
<RhMicronsCaretDownIcon />
3131
</span>
3232
);
3333

‎packages/react-core/src/components/Accordion/__tests__/AccordionToggle.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { AccordionToggle } from '../AccordionToggle';
44
import { AccordionContext, AccordionItemContext } from '../AccordionContext';
55
import styles from '@patternfly/react-styles/css/components/Accordion/accordion';
66

7-
jest.mock('@patternfly/react-icons/dist/esm/icons/rh-ui-caret-down-icon', () => () => 'Icon mock');
7+
jest.mock('@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon', () => () => 'Icon mock');
88

99
test('Renders without children', () => {
1010
render(

‎packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { useContext } from 'react';
22
import { Button, ButtonProps, ButtonVariant } from '../Button';
33
import { AlertContext } from './AlertContext';
4-
import RhUiCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-caret-down-icon';
4+
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
55
import { css } from '@patternfly/react-styles';
66
import styles from '@patternfly/react-styles/css/components/Alert/alert';
77

@@ -33,7 +33,7 @@ export const AlertToggleExpandButton: React.FunctionComponent<AlertToggleExpandB
3333
{...props}
3434
icon={
3535
<span className={css(styles.alertToggleIcon)}>
36-
<RhUiCaretDownIcon />
36+
<RhMicronsCaretDownIcon />
3737
</span>
3838
}
3939
/>

‎packages/react-core/src/components/Alert/__tests__/AlertToggleExpandButton.test.tsx‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,16 @@ import styles from '@patternfly/react-styles/css/components/Alert/alert';
88

99
jest.mock('../../Button');
1010

11-
jest.mock('@patternfly/react-icons/dist/esm/icons/rh-ui-caret-down-icon', () => () => 'Icon mock');
11+
jest.mock('@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon', () => () => 'Icon mock');
1212

1313
test('Renders without children', () => {
1414
render(
15-
<div data-testid="container">
16-
<AlertContext.Provider value={{ title: 'title', variantLabel: 'variantLabel' }}>
17-
<AlertToggleExpandButton />
18-
</AlertContext.Provider>
19-
</div>
15+
<AlertContext.Provider value={{ title: 'title', variantLabel: 'variantLabel' }}>
16+
<AlertToggleExpandButton />
17+
</AlertContext.Provider>
2018
);
2119

22-
expect(screen.getByTestId('container').firstChild).toBeVisible();
20+
expect(screen.getByRole('button')).toBeVisible();
2321
});
2422

2523
test('Renders with an aria label composed with the title and variantLabel provided via a context by default', () => {

‎packages/react-core/src/components/Breadcrumb/examples/Breadcrumb.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ ouia: true
88

99
import { useRef, useState } from 'react';
1010
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
11-
import RhUiCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-caret-down-icon';
11+
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
1212

1313
## Examples
1414

‎packages/react-core/src/components/Card/CardHeader.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { CardHeaderMain } from './CardHeaderMain';
55
import { CardActions } from './CardActions';
66
import { CardSelectableActions } from './CardSelectableActions';
77
import { Button } from '../Button';
8-
import RhUiCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-caret-down-icon';
8+
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
99
import { Radio } from '../Radio';
1010
import { Checkbox } from '../Checkbox';
1111
import { useSSRSafeId } from '../../helpers';
@@ -107,7 +107,7 @@ export const CardHeader: React.FunctionComponent<CardHeaderProps> = ({
107107
{...toggleButtonProps}
108108
icon={
109109
<span className={css(styles.cardHeaderToggleIcon)}>
110-
<RhUiCaretDownIcon />
110+
<RhMicronsCaretDownIcon />
111111
</span>
112112
}
113113
/>

‎packages/react-core/src/components/Card/__tests__/__snapshots__/CardHeader.test.tsx.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ exports[`CardHeader onExpand adds the toggle button 1`] = `
3939
fill="currentColor"
4040
height="1em"
4141
role="img"
42-
viewBox="0 0 32 32"
42+
viewBox="0 0 20 20"
4343
width="1em"
4444
>
4545
<path
46-
d="M16 24.792c-.384 0-.769-.146-1.061-.438L2.293 11.707a.999.999 0 1 1 1.414-1.414L16 22.586l12.293-12.293a.999.999 0 1 1 1.414 1.414L17.061 24.353a1.497 1.497 0 0 1-1.061.438Z"
46+
d="M18.71 5.29a.996.996 0 0 0-1.41 0l-7.29 7.29-7.3-7.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 7.65 7.65c.29.29.68.44 1.06.44s.77-.15 1.06-.44l7.65-7.65a.996.996 0 0 0 0-1.41Z"
4747
/>
4848
</svg>
4949
</span>

‎packages/react-core/src/components/ClipboardCopy/ClipboardCopyToggle.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy';
22
import { css } from '@patternfly/react-styles';
3-
import RhUiCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-caret-down-icon';
3+
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
44
import { Button } from '../Button';
55

66
export interface ClipboardCopyToggleProps extends Omit<
@@ -31,7 +31,7 @@ export const ClipboardCopyToggle: React.FunctionComponent<ClipboardCopyTogglePro
3131
{...props}
3232
icon={
3333
<div className={css(styles.clipboardCopyToggleIcon)}>
34-
<RhUiCaretDownIcon />
34+
<RhMicronsCaretDownIcon />
3535
</div>
3636
}
3737
/>

‎packages/react-core/src/components/DataList/DataListToggle.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { css } from '@patternfly/react-styles';
2-
import RhUiCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-caret-down-icon';
2+
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
33
import styles from '@patternfly/react-styles/css/components/DataList/data-list';
44
import { Button, ButtonProps, ButtonVariant } from '../Button';
55

@@ -44,7 +44,7 @@ export const DataListToggle: React.FunctionComponent<DataListToggleProps> = ({
4444
{...buttonProps}
4545
icon={
4646
<div className={css(styles.dataListToggleIcon)}>
47-
<RhUiCaretDownIcon />
47+
<RhMicronsCaretDownIcon />
4848
</div>
4949
}
5050
/>

‎packages/react-core/src/components/DataList/__tests__/__snapshots__/DataListToggle.test.tsx.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ exports[`Renders to match snapshot 1`] = `
3232
fill="currentColor"
3333
height="1em"
3434
role="img"
35-
viewBox="0 0 32 32"
35+
viewBox="0 0 20 20"
3636
width="1em"
3737
>
3838
<path
39-
d="M16 24.792c-.384 0-.769-.146-1.061-.438L2.293 11.707a.999.999 0 1 1 1.414-1.414L16 22.586l12.293-12.293a.999.999 0 1 1 1.414 1.414L17.061 24.353a1.497 1.497 0 0 1-1.061.438Z"
39+
d="M18.71 5.29a.996.996 0 0 0-1.41 0l-7.29 7.29-7.3-7.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 7.65 7.65c.29.29.68.44 1.06.44s.77-.15 1.06-.44l7.65-7.65a.996.996 0 0 0 0-1.41Z"
4040
/>
4141
</svg>
4242
</div>

0 commit comments

Comments
 (0)