Feedback from Austin and Katie

Author: Eric Olkowski

packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx

@@ -202,6 +202,15 @@ class ClipboardCopy extends React.Component<ClipboardCopyProps, ClipboardCopySta
 
     const copyableText = this.state.text;
     const shouldTruncate = variant === ClipboardCopyVariant.inlineCompact && truncation;
+    const inlineCompactContent = shouldTruncate ? (
+      <Truncate
+        refToGetParent={this.clipboardRef}
+        content={copyableText}
+        {...(typeof truncation === 'object' && truncation)}
+      />
+    ) : (
+      copyableText
+    );
 
     return (
       <div
@@ -222,28 +231,12 @@ class ClipboardCopy extends React.Component<ClipboardCopyProps, ClipboardCopySta
               <React.Fragment>
                 {!isCode && (
                   <span className={css(styles.clipboardCopyText)} id={`${textIdPrefix}${id}`}>
-                    {shouldTruncate ? (
-                      <Truncate
-                        refToGetParent={this.clipboardRef}
-                        content={copyableText}
-                        {...(typeof truncation === 'object' && truncation)}
-                      />
-                    ) : (
-                      copyableText
-                    )}
+                    {inlineCompactContent}
                   </span>
                 )}
                 {isCode && (
                   <code className={css(styles.clipboardCopyText, styles.modifiers.code)} id={`${textIdPrefix}${id}`}>
-                    {shouldTruncate ? (
-                      <Truncate
-                        refToGetParent={this.clipboardRef}
-                        content={copyableText}
-                        {...(typeof truncation === 'object' && truncation)}
-                      />
-                    ) : (
-                      copyableText
-                    )}
+                    {inlineCompactContent}
                   </code>
                 )}
                 <span className={css(styles.clipboardCopyActions)}>

packages/react-core/src/components/Truncate/Truncate.tsx

@@ -42,8 +42,9 @@ export interface TruncateProps extends React.HTMLProps<HTMLSpanElement> {
     | 'left-end'
     | 'right-start'
     | 'right-end';
-  /** The element whose parent to reference when calculating whether truncation should occur. This must be an ancestor
-   * of the ClipboardCopy, and must have a valid width value.
+  /** @hide The element whose parent to reference when calculating whether truncation should occur. This must be an ancestor
+   * of the ClipboardCopy, and must have a valid width value. For internal use only, do not use as it is not part of the public API
+   * and is subject to change.
    */
   refToGetParent?: React.RefObject<any>;
 }