Skip to content

Chore(ClipboardCopy): add tooltip to play icon #11583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 3 commits into from
Mar 4, 2025
Merged

Chore(ClipboardCopy): add tooltip to play icon #11583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ae2405
Chore(ClipboardCopy): add tooltip to play icon
Mash707 Feb 28, 2025
668227d
renamed state variable and added a callback
Mash707 Mar 3, 2025
14c0bb3
added tooltip to code block examples
Mash707 Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 33 additions & 15 deletions .../src/components/ClipboardCopy/examples/ClipboardCopyInlineCompactWithAdditionalAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,36 @@
import React from 'react';
import { ClipboardCopy, ClipboardCopyAction, Button } from '@patternfly/react-core';
import { ClipboardCopy, ClipboardCopyAction, Button, Tooltip } from '@patternfly/react-core';
import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon';

export const ClipboardCopyInlineCompactWithAdditionalAction: React.FunctionComponent = () => (
<ClipboardCopy
hoverTip="Copy"
clickTip="Copied"
variant="inline-compact"
additionalActions={
<ClipboardCopyAction>
<Button variant="plain" hasNoPadding aria-label="Run in web terminal" icon={<PlayIcon />} />
</ClipboardCopyAction>
}
>
2.3.4-2-redhat
</ClipboardCopy>
);
export const ClipboardCopyInlineCompactWithAdditionalAction: React.FunctionComponent = () => {
const [isRunning, setisRunning] = React.useState(false);
const runText: string = 'Run in web terminal';
const doneRunText: string = 'Running in web terminal';
return (
<ClipboardCopy
hoverTip="Copy"
clickTip="Copied"
variant="inline-compact"
additionalActions={
<ClipboardCopyAction>
<Tooltip
aria="none"
aria-live="polite"
content={isRunning ? doneRunText : runText}
onTooltipHidden={() => setisRunning(false)}
>
<Button
variant="plain"
hasNoPadding
aria-label="Run in web terminal"
icon={<PlayIcon />}
onClick={() => setisRunning(!isRunning)}
/>
</Tooltip>
</ClipboardCopyAction>
}
>
2.3.4-2-redhat
</ClipboardCopy>
);
};
26 changes: 24 additions & 2 deletions packages/react-core/src/components/CodeBlock/examples/CodeBlockBasic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@
import React from 'react';
import { CodeBlock, CodeBlockAction, CodeBlockCode, ClipboardCopyButton, Button } from '@patternfly/react-core';
import {
CodeBlock,
CodeBlockAction,
CodeBlockCode,
ClipboardCopyButton,
Button,
Tooltip
} from '@patternfly/react-core';
import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon';

export const BasicCodeBlock: React.FunctionComponent = () => {
const [copied, setCopied] = React.useState(false);
const [isRunning, setisRunning] = React.useState(false);
const runText: string = 'Run in web terminal';
const doneRunText: string = 'Running in web terminal';

const clipboardCopyFunc = (event, text) => {
navigator.clipboard.writeText(text.toString());
Expand Down Expand Up @@ -39,7 +49,19 @@ url: https://raw.githubusercontent.com/Azure-Samples/helm-charts/master/docs`;
</ClipboardCopyButton>
</CodeBlockAction>
<CodeBlockAction>
<Button variant="plain" aria-label="Play icon" icon={<PlayIcon />} />
<Tooltip
aria="none"
aria-live="polite"
content={isRunning ? doneRunText : runText}
onTooltipHidden={() => setisRunning(false)}
>
<Button
variant="plain"
aria-label="Run in web terminal"
icon={<PlayIcon />}
onClick={() => setisRunning(!isRunning)}
/>
</Tooltip>
</CodeBlockAction>
</React.Fragment>
);
Expand Down
20 changes: 18 additions & 2 deletions packages/react-core/src/components/CodeBlock/examples/CodeBlockExpandable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,17 @@ import {
ClipboardCopyButton,
ExpandableSection,
ExpandableSectionToggle,
Button
Button,
Tooltip
} from '@patternfly/react-core';
import PlayIcon from '@patternfly/react-icons/dist/esm/icons/play-icon';

export const ExpandableCodeBlock: React.FunctionComponent = () => {
const [isExpanded, setIsExpanded] = React.useState(false);
const [copied, setCopied] = React.useState(false);
const [isRunning, setisRunning] = React.useState(false);
const runText: string = 'Run in web terminal';
const doneRunText: string = 'Running in web terminal';

const onToggle = (isExpanded) => {
setIsExpanded(isExpanded);
Expand Down Expand Up @@ -60,7 +64,19 @@ url: https://raw.githubusercontent.com/Azure-Samples/helm-charts/master/docs`;
</ClipboardCopyButton>
</CodeBlockAction>
<CodeBlockAction>
<Button variant="plain" aria-label="Play icon" icon={<PlayIcon />} />
<Tooltip
aria="none"
aria-live="polite"
content={isRunning ? doneRunText : runText}
onTooltipHidden={() => setisRunning(false)}
>
<Button
variant="plain"
aria-label="Run in web terminal"
icon={<PlayIcon />}
onClick={() => setisRunning(!isRunning)}
/>
</Tooltip>
</CodeBlockAction>
</React.Fragment>
);
Expand Down
Loading