feat(toolbar): add hasNoPadding prop#11648
Merged
kmcfaul merged 1 commit intopatternfly:mainfrom Mar 12, 2025
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11648.surge.sh A11y report: https://patternfly-react-pr-11648-a11y.surge.sh |
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
This looks good to me, we just need to rebase the PR to get the latest core bump, and ideally we would have 2 new unit tests for the new prop (one to check the class isn't applied by default, one to check it is applied when hasNoPadding is true). LMK if you'd be up for adding such tests
kmcfaul
reviewed
Mar 11, 2025
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
+1 to @thatblindgeye's comment.
Otherwise lgtm
tlabaj
reviewed
Mar 12, 2025
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
Could you please add a unit test for the new prop
sg00dwin
force-pushed
the
7332-toolbar-no-padding
branch
from
36f3b90 to
2d0c130
Compare
thatblindgeye
approved these changes
Mar 12, 2025
kmcfaul
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11647
Additional issues: patternfly/patternfly#7332