feat(CC-button): added and validated button#11883
feat(CC-button): added and validated button#11883mattnolting wants to merge 2 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-11883.surge.sh A11y report: https://patternfly-react-pr-11883-a11y.surge.sh Preview: https://pf-react-pr-11883.surge.sh A11y report: https://pf-react-pr-11883-a11y.surge.sh |
mattnolting
force-pushed
the
feat-CC-button
branch
from
5019d6c to
343f026
Compare
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
| Tertiary: 'tertiary' | ||
| }), | ||
|
|
||
| children: figma.children('*') |
There was a problem hiding this comment.
children isn't used in this code connect.
| // enum | ||
| isClicked: figma.enum('State', { Clicked: true }), | ||
| isDisabled: figma.enum('State', { Disabled: true }), | ||
| leftOrRight: figma.enum('Left or Right', { |
There was a problem hiding this comment.
leftOrRight isn't used in this code connect.
mattnolting
force-pushed
the
feat-CC-button
branch
from
343f026 to
e49b7b2
Compare
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Only one thing I noticed
| <Button | ||
| countOptions={props.countOptions} | ||
| icon={props.icon} | ||
| iconPosition={props.icon} |
There was a problem hiding this comment.
this should be props.iconPosition i believe
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Closed per discussion due to new AI tooling which relieves the maintenance and tech debt that Code Connect manual files introduce. |
5 participants
Relates to: #11624
Included components:
Component tracker
Figma preview
Resources: