Skip to content

fix(Table): updated logic for expandable class #11918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlabaj merged 2 commits into from
Jul 11, 2025
Merged

fix(Table): updated logic for expandable class #11918

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83be769
fix(Table): updated logic for expandable class
thatblindgeye Jul 10, 2025
737641e
Bumped core for latest style updates
thatblindgeye Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-table/src/components/Table/Tr.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ const TrBase: React.FunctionComponent<TrProps> = ({
className={css(
styles.tableTr,
className,
isExpandable !== undefined && styles.tableExpandableRow,
// TODO: Revert this back to just isExpandable !== undefined and refine docs around expandable table structure --
// We should note where isExpanded and isExpandable props must be passed in
(isExpandable !== undefined || isExpanded !== undefined) && styles.tableExpandableRow,
isExpanded && styles.modifiers.expanded,
isEditable && inlineStyles.modifiers.inlineEditable,
isClickable && styles.modifiers.clickable,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-table/src/components/Table/__tests__/__snapshots__/RowWrapper.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ exports[`RowWrapper renders expanded correctly 1`] = `
<table>
<tbody>
<tr
class="pf-v6-c-table__tr pf-m-expanded"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row pf-m-expanded"
data-ouia-component-id="OUIA-Generated-TableRow-2"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down
38 changes: 19 additions & 19 deletions ...s/react-table/src/deprecated/components/Table/__tests__/__snapshots__/Table.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1602,7 +1602,7 @@ exports[`Table Collapsible nested table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-182"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -1697,7 +1697,7 @@ exports[`Table Collapsible nested table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-183"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -1853,7 +1853,7 @@ exports[`Table Collapsible nested table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-185"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -2360,7 +2360,7 @@ exports[`Table Collapsible table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr pf-m-expanded"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row pf-m-expanded"
data-ouia-component-id="OUIA-Generated-TableRow-167"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -2577,7 +2577,7 @@ exports[`Table Collapsible table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-170"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -2975,7 +2975,7 @@ exports[`Table Compound Expandable table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr pf-m-expanded"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row pf-m-expanded"
data-ouia-component-id="OUIA-Generated-TableRow-177"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -3041,7 +3041,7 @@ exports[`Table Compound Expandable table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-179"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -3183,7 +3183,7 @@ exports[`Table Control text table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-212"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -3234,7 +3234,7 @@ exports[`Table Control text table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-213"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -3341,7 +3341,7 @@ exports[`Table Control text table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-215"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -3742,7 +3742,7 @@ exports[`Table Header width table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-222"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -3793,7 +3793,7 @@ exports[`Table Header width table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-223"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -3900,7 +3900,7 @@ exports[`Table Header width table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-225"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -4359,7 +4359,7 @@ exports[`Table Selectable table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-192"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -4415,7 +4415,7 @@ exports[`Table Selectable table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-193"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -4540,7 +4540,7 @@ exports[`Table Selectable table 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-195"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -5048,7 +5048,7 @@ exports[`Table Selectable table with Radio 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-202"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -5104,7 +5104,7 @@ exports[`Table Selectable table with Radio 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-203"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down Expand Up @@ -5229,7 +5229,7 @@ exports[`Table Selectable table with Radio 1`] = `
</td>
</tr>
<tr
class="pf-v6-c-table__tr"
class="pf-v6-c-table__tr pf-v6-c-table__expandable-row"
data-ouia-component-id="OUIA-Generated-TableRow-205"
data-ouia-component-type="PF6/TableRow"
data-ouia-safe="true"
Expand Down
Loading