Skip to content

feat(CC-table): init table#12031

Closed
mattnolting wants to merge 1 commit intopatternfly:mainfrom
mattnolting:feat-CC-table
Closed

feat(CC-table): init table#12031
mattnolting wants to merge 1 commit intopatternfly:mainfrom
mattnolting:feat-CC-table

Conversation

@mattnolting
Copy link
Copy Markdown
Contributor

@mattnolting mattnolting commented Oct 1, 2025

TLDR

Table is mostly complete and partially functional.

A couple of notes:

Row based table = React component aligned table

Example:

<table />
  <thead /> <- though missing currently 
    <tr />
      <th />
  <tbody /> <- though missing currently 
    <tr />
      <th />

Column base tables = purely presentational/Figma usage only

Why is the column based table mis-aligned?
Figma structure dictates that row are structured vertically, which is inconsistent with html structural requirements.

The Figma Table component lacks <Thead> and <Tbody> equivalent. Table source code won't include these, thus will be semantically invalid.

Action items:

  • Followup with design, add missing elements @kaylachumley
  • Update .figma.tsx file to match newly added Figma elements.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions Bot added the Stale label Dec 4, 2025
@evwilkin evwilkin closed this Apr 10, 2026
@evwilkin
Copy link
Copy Markdown
Member

Closed per discussion due to new AI tooling which relieves the maintenance and tech debt that Code Connect manual files introduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants