-
Notifications
You must be signed in to change notification settings - Fork 382
feat(Progress): add hideStatusIcon flag #12038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thatblindgeye
merged 5 commits into
patternfly:main
from
gitdallas:feat/11983-Progress-disableStatusIcon-flag
Nov 3, 2025
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6c5dcc6
feat(Progress): add hideStatusIcon flag
gitdallas 975637d
avoid using test-id
gitdallas 1a78f46
interactive example for measureLocation and hideStatusIcon
gitdallas 0335d55
Update packages/react-core/src/components/Progress/ProgressContainer.tsx
gitdallas 7d5b892
Update packages/react-core/src/components/Progress/Progress.tsx
gitdallas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,6 +58,7 @@ export interface ProgressContainerProps extends Omit<React.HTMLProps<HTMLDivElem | |
| * We recommend the helper text component as it was designed for this purpose. | ||
| */ | ||
| helperText?: React.ReactNode; | ||
| hideStatusIcon?: boolean; | ||
|
gitdallas marked this conversation as resolved.
|
||
| } | ||
|
|
||
| const variantToIcon = { | ||
|
|
@@ -76,9 +77,10 @@ export const ProgressContainer: React.FunctionComponent<ProgressContainerProps> | |
| measureLocation = ProgressMeasureLocation.top, | ||
| isTitleTruncated = false, | ||
| tooltipPosition, | ||
| helperText | ||
| helperText, | ||
| hideStatusIcon = false | ||
| }: ProgressContainerProps) => { | ||
| const StatusIcon = variantToIcon.hasOwnProperty(variant) && variantToIcon[variant]; | ||
| const StatusIcon = !hideStatusIcon && variantToIcon.hasOwnProperty(variant) && variantToIcon[variant]; | ||
| const [tooltip, setTooltip] = useState(''); | ||
| const titleRef = useRef(null); | ||
| const updateTooltip = (event: any) => { | ||
|
|
@@ -124,7 +126,7 @@ export const ProgressContainer: React.FunctionComponent<ProgressContainerProps> | |
| <span className={css(progressStyle.progressMeasure)}>{label || `${value}%`}</span> | ||
| )} | ||
| {StatusIcon && ( | ||
| <span className={css(progressStyle.progressStatusIcon)}> | ||
| <span className={css(progressStyle.progressStatusIcon)} data-testid="progress-status-icon"> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really want to hard code this test id into the component? I'm not sure what a better way to do it would be, but I don't love this, and the fact that there isn't a better way is probably signaling a lack of a11y on this. Would love @thatblindgeye's thoughts on this. |
||
| <StatusIcon /> | ||
| </span> | ||
| )} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.