Skip to content

feat(card): add isGlass prop #12290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatblindgeye merged 2 commits into from
Mar 27, 2026
Merged

feat(card): add isGlass prop #12290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bf0c2c
feat(card): add isGlass prop
wise-king-sullyman Mar 24, 2026
7fc63e6
Update packages/react-core/src/components/Card/Card.tsx
wise-king-sullyman Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-core/src/components/Card/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ export interface CardProps extends React.HTMLProps<HTMLElement>, OUIAProps {
isFullHeight?: boolean;
/** Modifies the card to include plain styling; this removes border and background */
isPlain?: boolean;
/** Modifies the card to include glass styling */
Copy link
Copy Markdown
Contributor

@nicolethoen nicolethoen Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be worth clarifying that it'll include glass styling when the glass contrast mode is enabled?

isGlass?: boolean;
/** Flag indicating if a card is expanded. Modifies the card to be expandable. */
isExpanded?: boolean;
/** Card background color variant */
Expand Down Expand Up @@ -81,6 +83,7 @@ const CardBase: React.FunctionComponent<CardProps> = ({
isLarge = false,
isFullHeight = false,
isPlain = false,
isGlass = false,
variant = 'default',
ouiaId,
ouiaSafe = true,
Expand Down Expand Up @@ -138,6 +141,7 @@ const CardBase: React.FunctionComponent<CardProps> = ({
isLarge && styles.modifiers.displayLg,
isFullHeight && styles.modifiers.fullHeight,
isPlain && styles.modifiers.plain,
isGlass && styles.modifiers.glass,
variant === 'secondary' && styles.modifiers.secondary,
getSelectableModifiers(),
isDisabled && styles.modifiers.disabled,
Expand Down
5 changes: 5 additions & 0 deletions packages/react-core/src/components/Card/__tests__/Card.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ describe('Card', () => {
expect(consoleWarnMock).toHaveBeenCalled();
});

test('card with isGlass applied', () => {
render(<Card isGlass>glass card</Card>);
expect(screen.getByText('glass card')).toHaveClass('pf-m-glass');
});

test('card with variant set to secondary ', () => {
render(<Card variant="secondary">secondary card</Card>);

Expand Down
Loading