fix(vertical tabs): update with unified tokens#99
Open
jcmill wants to merge 5 commits into
Open
Conversation
…te tab border radius, spacing, color, and hover background color
Author
|
(fixed) I'm looking into the jest failures. |
mcoker
requested changes
Jun 10, 2026
mcoker
left a comment
mcoker
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of comments, otherwise looks great!
|
|
||
| > a { | ||
| color: var( --pf-t--global--text--color--regular); | ||
| color: var( --pf-t--global--text--color--subtle); |
Contributor
There was a problem hiding this comment.
Just want to make sure this was confirmed in design? It matches figma, but wasn't called out as a change to make. Also figma uses the default text color for the active/selected tab state, so if we would want to confirm that if we make this change, too.
Author
There was a problem hiding this comment.
Got more info from Design on this and updated for default to be subtle and hover/active to be default.
| text-decoration: none; | ||
| display: block; | ||
| margin-inline-start: var(--pf-t--global--spacer--md); | ||
| margin-inline-start: calc(var(--pf-t--global--spacer--md) - 3px); |
Contributor
There was a problem hiding this comment.
Want to reference the var here in case the value for that border width token ever changes.
Suggested change
| margin-inline-start: calc(var(--pf-t--global--spacer--md) - 3px); | |
| margin-inline-start: calc(var(--pf-t--global--spacer--md) - var(--pf-t--global--border--width--extra-strong)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #96
version bumps on PatterFly deps to v6.5.x
update to unified tokens for vertical tab styles
update to scss @import to @use