Skip to content

Commit aa13f80

Browse files
rhamiltoclaude
andcommitted
fix(BulkSelect): use specific parameter names to avoid i18n keyword conflicts
Updated function parameter names from generic 'count' to specific names (pageCount, totalCount, selectedCount) to avoid conflicts with i18n libraries like react-i18next where 'count' is a reserved keyword for pluralization. This ensures better compatibility when using the component with i18n libraries without naming collisions. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 83a09dc commit aa13f80

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/module/src/BulkSelect/BulkSelect.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ describe('BulkSelect component', () => {
8282
pagePartiallySelected={true}
8383
onSelect={() => null}
8484
selectNoneLabel="Aucune sélection (0)"
85-
selectPageLabel={(count) => `Sélectionner la page${count ? ` (${count})` : ''}`}
86-
selectAllLabel={(count) => `Tout sélectionner${count ? ` (${count})` : ''}`}
87-
selectedLabel={(count) => `${count} sélectionné${count > 1 ? 's' : ''}`}
85+
selectPageLabel={(pageCount) => `Sélectionner la page${pageCount ? ` (${pageCount})` : ''}`}
86+
selectAllLabel={(totalCount) => `Tout sélectionner${totalCount ? ` (${totalCount})` : ''}`}
87+
selectedLabel={(selectedCount) => `${selectedCount} sélectionné${selectedCount > 1 ? 's' : ''}`}
8888
/>
8989
);
9090

0 commit comments

Comments
 (0)