Skip to content

feat(DataView): add support for resizable columns #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 29 commits into from
Oct 1, 2025
Merged

feat(DataView): add support for resizable columns #512

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ad99460
feat(DataView): add support for resizable columns
kmcfaul Sep 19, 2025
e974b13
fix spread props & lint, shortcut useeffects for non-resize cols, moc…
kmcfaul Sep 19, 2025
89fef7d
resolve lint spacing
kmcfaul Sep 19, 2025
6455bb8
refactor props to single interface, add aria label to button, add shi…
kmcfaul Sep 22, 2025
ebb15c2
update keyboard interaction
kmcfaul Sep 23, 2025
b020101
remove preventDefault for non arrow keys
kmcfaul Sep 23, 2025
e21ec67
add useState to .md
kmcfaul Sep 23, 2025
37674b8
add other missing function
kmcfaul Sep 23, 2025
5a7b0e0
updated example to properly update srtext
kmcfaul Sep 23, 2025
b4e33cd
remove console log
kmcfaul Sep 23, 2025
88466f9
remove unused helper call in example
kmcfaul Sep 23, 2025
0d23398
move onResize for keyboard
kmcfaul Sep 23, 2025
e4bbb26
round srtext width
kmcfaul Sep 23, 2025
4025dfa
update srtext to be in state
kmcfaul Sep 23, 2025
7f27aaa
clean up width logic and srtext
kmcfaul Sep 23, 2025
1ddd1e4
update sr prop name
kmcfaul Sep 23, 2025
3f51e93
update some prop desc, remove default aria label and add warning if n…
kmcfaul Sep 26, 2025
c4c313d
update example docs
kmcfaul Sep 26, 2025
9c1e385
update prop desc for resizableProps
kmcfaul Sep 26, 2025
f89d922
chore: style resize button
mcoker Sep 26, 2025
b4507af
fix callback width returning 0, add id to callback, add aria label to…
kmcfaul Sep 26, 2025
41f26d2
fix lint
kmcfaul Sep 26, 2025
f4a5d2e
remove resize from sort column
kmcfaul Sep 26, 2025
ea9f17b
fix typo in docs
kmcfaul Sep 26, 2025
9c0eb6b
chore: use grabbing cursor on resize
mcoker Sep 29, 2025
df5499f
update to main prerelease versions, add back resize to sort column in…
kmcfaul Sep 29, 2025
9117942
remove span
kmcfaul Sep 29, 2025
facc679
update snap from pulling in new versions
kmcfaul Sep 29, 2025
6f2e993
disabled array-bracket-spacing rule to match prettier config, fix lin…
kmcfaul Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions config/setupTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,15 @@ global.MutationObserver = class {
observe(element, initObject) {}
};

global.IntersectionObserver = class {
constructor(callback, options) {}
disconnect() {}
observe(element) {}
unobserve(element) {}
};

jest.mock('react', () => ({
...jest.requireActual('react'),
useLayoutEffect: jest.requireActual('react').useEffect,
useLayoutEffect: jest.requireActual('react').useEffect
}));
Element.prototype.scrollTo = () => {};
Element.prototype.scrollTo = () => {};
208 changes: 186 additions & 22 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions packages/module/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
},
"dependencies": {
"@patternfly/react-component-groups": "^6.1.0",
"@patternfly/react-core": "^6.0.0",
"@patternfly/react-icons": "^6.0.0",
"@patternfly/react-table": "^6.0.0",
"@patternfly/react-core": "6.4.0-prerelease.1",
"@patternfly/react-icons": "6.4.0-prerelease.1",
"@patternfly/react-table": "6.4.0-prerelease.2",
"clsx": "^2.1.1",
"react-jss": "^10.10.0"
},
Expand All @@ -44,8 +44,8 @@
},
"devDependencies": {
"@patternfly/documentation-framework": "^6.5.20",
"@patternfly/patternfly": "^6.0.0",
"@patternfly/react-code-editor": "^6.0.0",
"@patternfly/patternfly": "6.4.0-prerelease.1",
"@patternfly/react-code-editor": "6.4.0-prerelease.1",
"@patternfly/patternfly-a11y": "^5.1.0",
"@types/react": "^18.3.23",
"@types/react-dom": "^18.3.7",
Expand Down
Loading
Loading