chore(demo app): Fix build of demo app and center graph initially#284
Merged
jeff-phillips-18 merged 1 commit intoJun 23, 2025
Merged
Conversation
thatblindgeye
approved these changes
Jun 20, 2025
jenny-s51
reviewed
Jun 20, 2025
Collaborator
jenny-s51
left a comment
There was a problem hiding this comment.
Great work @jeff-phillips-18 ! Graph centering looks awesome - I'm still seeing a couple of errors being thrown by webpack in the demo-app build which we can resolve with these two quick fixes - PRed your changes: jeff-phillips-18#2
jenny-s51
approved these changes
Jun 20, 2025
Collaborator
jenny-s51
left a comment
There was a problem hiding this comment.
Thanks @jeff-phillips-18 ! Tested in docs workspace and demo app. Graph centering now works as expected and demo app builds successfully. LGTM
|
🎉 This PR is included in version 6.3.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The demo application does not build due to:
Fixing this issue reveals that the graph is no longer being centered in the
TopologyPackagedemo.This PR fixes the build issue and fixes centering the graph in the demo
Type of change