Add an exception for GoogleGemini and GoogleVertexAI when using the OutputFixingParser#1016
Open
carlows wants to merge 1 commit intopatterns-ai-core:mainfrom
Open
Add an exception for GoogleGemini and GoogleVertexAI when using the OutputFixingParser#1016carlows wants to merge 1 commit intopatterns-ai-core:mainfrom
carlows wants to merge 1 commit intopatterns-ai-core:mainfrom
Conversation
…utputFixingParser
konzinov
reviewed
Nov 29, 2025
| error: e | ||
| )}] | ||
| messages: chat_messages(completion, e) | ||
| ).completion |
There was a problem hiding this comment.
the call to .completion here should be .chat_completion for Vertex and Gemini LLM clients.
Otherwise it raises NotImplementedError: NotImplementedError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to #1015
As described in the README, the google APIs have a different format for their LLMs:
And the OutputFixingParser class doesn't work with Gemini 2.5-flash, as it throws the following error:
The goal of this PR is to use the correct format instead.