Add support for Amazon Nova models#929
Open
tpaulshippy wants to merge 7 commits intopatterns-ai-core:mainfrom
Open
Add support for Amazon Nova models#929tpaulshippy wants to merge 7 commits intopatterns-ai-core:mainfrom
tpaulshippy wants to merge 7 commits intopatterns-ai-core:mainfrom
Conversation
Contributor
|
@andreibondarev this is looking good to me. Are we able to get test runs going? |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
lib/langchain/llm/aws_bedrock.rb:305
- Consider whether additional keys such as :top_p, :top_k, and :stop_sequences should also be removed after merging them into inferenceConfig to avoid potential duplication or inconsistencies in the parameters.
params.reject { |k, _| k == :max_tokens || k == :temperature }
|
Any progress on this? We have some usecases for Nova models and would like to use them with langchain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses #928
Approach
Add support for Amazon models in AwsBedrock and introduce AwsBedrockAmazonResponse.
Testing
Ran against Nova Micro.
RSpec