271 feature implementation of columntransformer support#279
Open
fernandonbarros wants to merge 3 commits into
Open
271 feature implementation of columntransformer support#279fernandonbarros wants to merge 3 commits into
fernandonbarros wants to merge 3 commits into
Conversation
Author
|
It looks like the update to the PLSRegression API introduced a bug in the PLSRegressionInspector that was not caught be any of the existing tests. I created an additional commit to address the bug that was introduced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLSRegressiontransformer to add compatibility with sklearn'sColumnTransformer.transform_out="pandas", thePLSRegressiontransformer will output scores as a dataframe with columnsLV1toLVn.test_optional_dependenciestest failing.Why is this change needed?
Closes
Related issues
Type of change
What changed?
chemotools/regression/_pls_regression.py:get_feature_names_outmethod to return an array["LV1" ... "LVn"]to serve as column names for scores dataframe.transformmethod to add a flag to define ify_scoresshould be returned by the method.chemotools/tests/regression/test_pls_regression.py:test_works_with_column_transformertest to ensure that thePLSRegressiontransformer is compatible with theColumnTransformer.chemotools/_optional.pyandchemotools/tests/utils/test_optional_dependencies.pyto fix issues with thetest_import_optional_dependency_real_optionaltest.What did NOT change?
PLSRegressionwere modified.API and compatibility impact
Notes
PLSRegressionclass inchemotools/regression/_pls_regression.pywas updated.import_optional_dependencyfunction inchemotools/_optional.pywas updated.PLSRegressiontransformer is used and expecty_scoresto be returned should be modified to include thereturn_y=Trueflag.Validation
task format-checktask linttask spellingtask type-checktask testtask coveragetask test:matrixtask docs:checktask buildValidation notes
test_import_optional_dependency_real_optionalwas originally failing, but issue was addressed by updating the test and theimport_optional_dependencyfunction.task docs:checkTests
Test coverage details
chemotools/tests/utils/test_optional_dependencies.pychemotools/tests/regression/test_pls_regression.pyPLSRegressionin a pipeline withColumnTransformerwhere thetransform_output="pandas"Documentation
Documentation notes
Dependency / build / CI impact
Notes
Reviewer focus
Please focus on:
transformand the newget_feature_names_outmethods forPLSRegression.utilsandPLSRegression.Screenshots / logs / benchmark output
Details
Checklist