build: Fix cppcheck issues

Author: WerWolv

generators/include/pl/formatters/formatter.hpp

@@ -33,7 +33,7 @@ namespace pl::gen::fmt {
         void enableMetaInformation(bool enable) { this->m_metaInformation = enable; }
         [[nodiscard]] bool isMetaInformationEnabled() const { return this->m_metaInformation; }
 
-        std::vector<std::pair<std::string, std::string>> getMetaInformation(ptrn::Pattern *pattern) const {
+        std::vector<std::pair<std::string, std::string>> getMetaInformation(const ptrn::Pattern *pattern) const {
             if (!this->m_metaInformation)
                 return { };
 

generators/include/pl/formatters/formatter_html.hpp

@@ -18,7 +18,7 @@ namespace pl::gen::fmt {
         }
 
     private:
-        static std::string generateTooltip(std::vector<ptrn::Pattern*> &patterns) {
+        static std::string generateTooltip(const std::vector<ptrn::Pattern*> &patterns) {
             if (patterns.empty())
                 return "";
 

lib/include/pl/api.hpp

@@ -41,7 +41,7 @@ namespace pl::api {
         std::string content;
         std::string source;
         u32 id = 0;
-        bool mainSource;
+        bool mainSource = false;
 
          Source(std::string content, std::string source = DefaultSource, bool mainSource = false) :
             content(std::move(content)), source(std::move(source)), mainSource(mainSource) {

lib/include/pl/core/errors/error.hpp

@@ -100,7 +100,7 @@ namespace pl::core::err {
         }
 
     private:
-        char m_prefix;
+        char m_prefix = 'E';
         u32 m_errorCode;
         std::string m_title;
     };

lib/include/pl/core/evaluator.hpp

@@ -328,7 +328,6 @@ namespace pl::core {
 
         [[nodiscard]] std::optional<Token::Literal> getEnvVariable(const std::string &name) const {
             if (this->m_envVariables.contains(name)) {
-                auto value = this->m_envVariables.at(name);
                 return this->m_envVariables.at(name);
             } else
                 return std::nullopt;
@@ -477,7 +476,7 @@ namespace pl::core {
         }
 
     private:
-        PatternLanguage *m_patternLanguage;
+        PatternLanguage *m_patternLanguage = nullptr;
         std::list<PatternLanguage> m_subRuntimes;
 
         u64 m_currOffset = 0x00;

lib/include/pl/core/lexer.hpp

@@ -67,6 +67,6 @@ namespace pl::core {
         u32 m_line = 0;
         u32 m_lineBegin = 0;
         size_t m_longestLineLength = 0;
-        u32 m_errorLength;
+        u32 m_errorLength = 0;
     };
 }

lib/include/pl/core/token.hpp

@@ -248,7 +248,7 @@ namespace pl::core {
 
         using ValueTypes = std::variant<Keyword, Identifier, Operator, Literal, ValueType, Separator, Comment, DocComment, Directive>;
 
-        constexpr Token(const Type type, auto value, const Location location) : type(type), value(std::move(value)), location(location) {}
+        constexpr Token(const Type type, auto value, const Location &location) : type(type), value(std::move(value)), location(location) {}
 
         [[nodiscard]] constexpr static bool isInteger(const ValueType &type) {
             return isUnsigned(type) || isSigned(type);
@@ -278,9 +278,9 @@ namespace pl::core {
         bool operator==(const ValueTypes &other) const;
         bool operator!=(const ValueTypes &other) const;
 
-        Type type;
-        ValueTypes value;
-        Location location;
+        Type type = {};
+        ValueTypes value = {};
+        Location location = {};
 
     };
 

lib/include/pl/helpers/utils.hpp

@@ -106,15 +106,15 @@ namespace pl::hlp {
     }
 
     template<typename T, typename... Args>
-    void moveToVector(std::vector<T> & buffer, Args &&...rest) {
+    void moveToVectorBuffer(std::vector<T> & buffer, Args &&...rest) {
         buffer.reserve(sizeof...(rest));
         (buffer.push_back(std::move(rest)),...);
     }
 
     template<typename T, typename... Args>
     [[nodiscard]] std::vector<T> moveToVector(T &&first, Args &&...rest) {
         std::vector<T> result;
-        moveToVector(result, std::move(first), std::move(rest)...);
+        moveToVectorBuffer(result, std::move(first), std::move(rest)...);
 
         return result;
     }

lib/include/pl/patterns/pattern.hpp

@@ -288,9 +288,9 @@ namespace pl::ptrn {
         }
 
         [[nodiscard]] virtual core::Token::Literal getValue() const {
-            auto clone = this->clone();
+            auto pattern = this->clone();
 
-            return this->transformValue(std::move(clone));
+            return this->transformValue(std::move(pattern));
         }
 
         [[nodiscard]] virtual std::vector<std::pair<u64, Pattern*>> getChildren() {

lib/include/pl/patterns/pattern_bitfield.hpp

@@ -222,10 +222,6 @@ namespace pl::ptrn {
             return "enum " + Pattern::getTypeName();
         }
 
-        [[nodiscard]] std::string getTypeName() const override {
-            return Pattern::getTypeName();
-        }
-
         void setEnumValues(const std::map<std::string, PatternEnum::EnumValue> &enumValues) {
             this->m_enumValues = enumValues;
         }
@@ -544,7 +540,7 @@ namespace pl::ptrn {
                 : PatternBitfieldMember(evaluator, offset, size_t((totalBitSize + 7) / 8), line), m_firstBitOffset(firstBitOffset), m_totalBitSize(totalBitSize) { }
 
         PatternBitfield(const PatternBitfield &other) : PatternBitfieldMember(other) {
-            for (auto &field : other.m_fields)
+            for (const auto &field : other.m_fields)
                 this->m_fields.push_back(field->clone());
 
             this->m_firstBitOffset = other.m_firstBitOffset;