You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Been using this build and everything is working fine, not sure what all the requirements are to make the cut in the next release. This is not a new feature, just a UX improvement imo.
I tried to make it as non-intrusive and no maintenance as possible.
Edit: please let me know about the workflow concurrency change, from personal experience, it is a nice edit to have when many people are pushing fast changes to a branch. Saves on time and money :)
Are we interested in this as well for the upcoming 1.5.3 release that is being bundled or should we close it without merging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/firmware-config-shortcut.js.Firmware Configshortcut into Fluidd and Mainsail during firmware build./firmware-config/.Scope
This PR is focused on issue #570 and the build workflow concurrency helper.
It does not include Anycubic ACE, RFID, or other experimental integration changes.
Visual example of what this looks like
Checks
git diff --checkbash -n overlays/firmware-extended/69-app-firmware-config-shortcut/scripts/01-inject-shortcut.shCloses #570