Skip to content

Commit 1345567

Browse files
committed
Remove (bugggy) no-tests workarounds
The no-coverage-report special case hid real coverage build failures unintentionally.
1 parent 5575384 commit 1345567

1 file changed

Lines changed: 1 addition & 9 deletions

File tree

nix/checks.nix

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
strictDeps = true;
2929
cargoArtifacts = deps;
3030
CARGO_PROFILE = profile;
31-
cargoNextestExtraArgs = "--no-tests=warn";
3231
};
3332

3433
testChecks = pkgs.lib.concatMapAttrs (
@@ -51,14 +50,7 @@
5150
nativeBuildInputs = [ pkgs.cargo-llvm-cov ];
5251
buildPhaseCargoCommand = ''
5352
mkdir -p $out
54-
cargo llvm-cov --all-features --lcov --output-path $out/coverage.lcov || {
55-
# no coverage data when there are no tests yet
56-
if [ ! -s $out/coverage.lcov ]; then
57-
echo "no coverage data (no tests), skipping assertion"
58-
exit 0
59-
fi
60-
exit 1
61-
}
53+
cargo llvm-cov --all-features --lcov --output-path $out/coverage.lcov
6254
cargo llvm-cov report --fail-under-regions 100
6355
'';
6456
installPhase = "true";

0 commit comments

Comments
 (0)