Replaying the event log results in "expired" error for successfully completed sessions

[spacebear21]

❯ cargo run -- history
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s
     Running `/Users/spacebear/Projects/rust-payjoin/target/debug/payjoin-cli history`
Session ID   Sender/Receiver           Completed At    Status
25           Receiver                  Not Completed   Session expired at Time(Time(1778362082))
1            Receiver                  1778275755      Session expired at Time(Time(1761155560))
2            Receiver                  1778275755      Session expired at Time(Time(1761234352))

Sessions 1 and 2 were completed but display the "expired" status erroneously.

[spacebear21]

This is actually a bug in replay_event_log, because it returns an Expiration error upon replay if the expiration duration has elapsed.

[zealsham]

@spacebear21 I’ll work on this if you’re not currently working on it already

[Spacebear]

@Spacebear I’ll work on this if you’re not currently working on it already

Hi I think you meant @spacebear21

[zealsham]

@Spacebear I’ll work on this if you’re not currently working on it already

Hi I think you meant @spacebear21

omg!, i'm so sorry for the tag. i blindly trusted github suggestion

[benalleng]

We only want this error when the session still beleives that the session is active so something like

// deleted as it did not work

should be sufficient IMO Edit: this did not work as expected so I think I need to rethink what this block is looking for

[zealsham]

i was able to trace this to constructHistory for both receive and send returning InternalReplayError::Expired if expiration has elpased