Remove unneeded http feature via the bhttp dep in payjoin-mailroom#1481
Merged
benalleng merged 1 commit intopayjoin:masterfrom Apr 15, 2026
Merged
Remove unneeded http feature via the bhttp dep in payjoin-mailroom#1481benalleng merged 1 commit intopayjoin:masterfrom
benalleng merged 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Coverage Report for CI Build 24421371865Coverage remained the same at 84.34%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
xstoicunicornx
approved these changes
Apr 15, 2026
Contributor
xstoicunicornx
left a comment
xstoicunicornx
left a comment
There was a problem hiding this comment.
Ack 4202617
Reviewed changes and ran tests. Lgtm.
arminsabouri
approved these changes
Apr 15, 2026
Collaborator
arminsabouri
left a comment
arminsabouri
left a comment
There was a problem hiding this comment.
Ack
http is a needed dep elsewhere
FWIW I don't see this feature used anywhere else
caarloshenriq
approved these changes
Apr 15, 2026
Contributor
caarloshenriq
left a comment
caarloshenriq
left a comment
There was a problem hiding this comment.
tACK 4202617
Ran locally, everything compiled and tests passed cleanly:
cargo build --all-features
cargo test --all-features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out from #1377 as this is not really related to that directly.
I think this was not caught by machete as http is a needed dep elsewhere?
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.