Cli cancel UX#1700
Open
benalleng wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
@spacebear21 I am most curious of your thoughts on 9b718ac and whether you think this is appropriate for both the |
Collaborator
Coverage Report for CI Build 28619046692Coverage decreased (-0.1%) to 85.838%Details
Uncovered Changes
Coverage Regressions13 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
bc1cindy
reviewed
Jun 30, 2026
bc1cindy
left a comment
bc1cindy
left a comment
Contributor
There was a problem hiding this comment.
looks solid
two notes inline on the expiry paths.
the new mid-loop cancel/broadcast and the fallback_available display aren't covered by tests
adding a test driving an expired session through the sender path would lock in the behavior, wdyt?
Before this change there was no reasonable way of knowing which session had a fallback transaction available meaning that if the session was closed with `payjoin-cli cancel # --no-broadcast` a user would have to enumerate through all the sessions trying to look for which session had the fallback tx.
benalleng
force-pushed
the
cli-UI-additions
branch
from
9b718ac to
9aa7f30
Compare
This ensures that the session id is printed immediately after session id creation ensuring that the session id is displayed at the earliest moment it is readable.
benalleng
force-pushed
the
cli-UI-additions
branch
3 times, most recently
from
c91653e to
597ffe4
Compare
benalleng
force-pushed
the
cli-UI-additions
branch
from
597ffe4 to
b241374
Compare
Previously the cli only checked for expiry at program start during long polling loops there was not an expiry check leading to the possiblity of an indefinite poll past expiry where the counterparty had already given up. This also adds an `--expire-in` flag for the receiver to both test this functionality and demonstrate that the receiver is not actually fixed to a 24hr expiration and is in controll of this expiry time.
benalleng
force-pushed
the
cli-UI-additions
branch
from
b241374 to
8d063a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #1688 but reverts the
completed_atDB column removal.payjoin-cli historyfor rebroadcasting.example output. custom timeout of 20s to demonstrate automatic cancel logic
Coded with help from GLM-5.2
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.