Rename FFI builder errors to match payjoin crate#1733
Draft
xstoicunicornx wants to merge 1 commit into
Draft
Conversation
Rename SenderBuilderError to BuildSenderError and ReceiverBuilderError to BuildReceiverError in payjoin-ffi so the FFI error names mirror the core payjoin crate's naming convention (e.g. payjoin::send::BuildSenderError).
Collaborator
Coverage Report for CI Build 29263197122Coverage remained the same at 86.01%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
reviewed
Jul 13, 2026
| /// Sender Build error | ||
| #[error(transparent)] | ||
| Build(Arc<SenderBuilderError>), | ||
| Build(Arc<BuildSenderError>), |
Collaborator
There was a problem hiding this comment.
Maybe you could make this Builder to prevent the collision?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename SenderBuilderError to BuildSenderError and
ReceiverBuilderError to BuildReceiverError in payjoin-ffi so the FFI error names mirror the core payjoin crate's naming convention (e.g. payjoin::send::BuildSenderError).
This is a follow up from suggestion made in #1724 (comment).
Claude Fable was used to make these code updates.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.