Open
Conversation
jbaifigma
requested review from
DanRibbens,
GermanJablo and
r1tsuu
and removed request for
DanRibbens and
r1tsuu
Collaborator
Author
|
@GermanJablo I know you suggested Vitest tags, would require to bump vitest to 4.1 and not sure if that would cause any issues. Can definitely use tags after we get the unit tests all passing. |
Contributor
|
Yes I started working on that |
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Disables unit tests described in this doc for the content api:
https://docs.google.com/document/d/120xmnUUCii_d7Tc4kvqItWV0D3td5RVCzM5JeWQ48Gk/edit?tab=t.0
Why?
The content api isn't going to support the above features/complex query patterns, though that may (will) change in the future.
How?
Early returns from tests if the db is the content-api
Fixes #
Reran test:int:summary, saw the following output:
Ran with the following commits:
Figma: 03d0e73d2b8f52c360c82f0a359d07397ad1d666
Enterprise-Plugins: 759a79b282f14f1e9815cf423cd84374f7414b0a
📈 Overall Results:
Suites: 33/48 passed
Tests: 1766/1871 passed
Time: 8m 13s
❌ Failed or partially failed suites:
⚠️ collections-rest (109/112)
⚠️ database (127/158)
⚠️ folders (11/14)
⚠️ joins (71/75)
⚠️ kv (2/3)
⚠️ localization (111/115)
⚠️ plugin-import-export (178/188)
⚠️ plugin-mcp (66/67)
⚠️ relationships (51/57)
⚠️ sdk (35/38)
⚠️ select (113/114)
⚠️ sort (33/37)
⚠️ uploads (91/93)
⚠️ versions (70/93)
⚠️ fields (148/157)