fix: allow cross-site navigate-mode cookie auth when csrf is configured#16177
Open
aqib-io wants to merge 1 commit intopayloadcms:mainfrom
Open
fix: allow cross-site navigate-mode cookie auth when csrf is configured#16177aqib-io wants to merge 1 commit intopayloadcms:mainfrom
aqib-io wants to merge 1 commit intopayloadcms:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Allow cookie-based authentication for cross-site top-level navigations (e.g. clicking a link from an email) when
csrfis configured.Why?
When
csrfis configured and a user clicks a link from an external source (email client, OAuth callback, another site), theSec-Fetch-Site: cross-siteheader causes the cookie to be rejected. This makes the user appear logged out on the first load.How?
Sec-Fetch-Mode: navigatecheck to cookie extraction inextractJWT.tsSec-Fetch-Modeis a forbidden header that cannot be spoofed by JavaScript — only set by the browser for genuine page navigationsSameSite=Lax(Payload default), cross-site POST/XHR attacks remain blockedFixes #16031